Skip to content

Fix array_intersect for array<array<T>>#23890

Merged
kewang1024 merged 1 commit intoprestodb:masterfrom
kewang1024:fix-array_intersect
Oct 29, 2024
Merged

Fix array_intersect for array<array<T>>#23890
kewang1024 merged 1 commit intoprestodb:masterfrom
kewang1024:fix-array_intersect

Conversation

@kewang1024
Copy link
Collaborator

@kewang1024 kewang1024 commented Oct 25, 2024 •
edited
Loading

#23887

== RELEASE NOTES ==

General Changes
* Fix array_intersect for single parameter array<array<T>> to be deterministic regardless of the order of null input:pr:`23890`

@kewang1024 kewang1024 requested a review from a team as a code owner October 25, 2024 19:48
spershin
spershin previously approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@spershin spershin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!
One more correctness issue is down.

@spershin
Copy link
Contributor

spershin commented Oct 28, 2024

@kewang1024
Looks like this triggered some E2E test failures, please, take a look, maybe expectations are wrong?

Error: TestHiveDistributedNanQueries>AbstractTestNanQueries.testDoubleArrayIntersect2:729-

Error: TestHiveDistributedNanQueries>AbstractTestNanQueries.testRealArrayIntersect2:738-

@kewang1024 kewang1024 merged commit d3051d6 into prestodb:master Oct 29, 2024
@jaystarshot jaystarshot mentioned this pull request Nov 1, 2024
Merged
25 tasks
@tdcmeehan tdcmeehan added the from:Meta PR from Meta label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NikhilCollooru NikhilCollooru NikhilCollooru approved these changes

@spershin spershin spershin left review comments

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

@amitkdutta amitkdutta Awaiting requested review from amitkdutta

@jaystarshot jaystarshot Awaiting requested review from jaystarshot jaystarshot is a code owner

@feilong-liu feilong-liu Awaiting requested review from feilong-liu feilong-liu is a code owner

@elharo elharo Awaiting requested review from elharo elharo is a code owner

@vivek-bharathan vivek-bharathan Awaiting requested review from vivek-bharathan

Assignees

No one assigned

Labels

from:Meta PR from Meta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kewang1024 @spershin @NikhilCollooru @tdcmeehan

Comments