Remove using namespace from header files#23575
Merged
rschlussel merged 1 commit intoprestodb:masterfrom Sep 6, 2024
Merged
Conversation
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D56538909 |
r-barnes
added a commit
to r-barnes/presto
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: prestodb#23575 Per title #buildmore - Be thorough #buildsonlynotests - No runtime effects! - If you approve of this diff, please use the "Accept & Ship" button no-ig-test - Doesn't require Instagram testing. (1 file modified.) Reviewed By: dmm-fb Differential Revision: D56538909
r-barnes
force-pushed
the
export-D56538909
branch
from
042dfa1 to
3c82607
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D56538909 |
r-barnes
added a commit
to r-barnes/presto
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: prestodb#23575 Per title #buildmore - Be thorough #buildsonlynotests - No runtime effects! - If you approve of this diff, please use the "Accept & Ship" button no-ig-test - Doesn't require Instagram testing. (1 file modified.) Reviewed By: dmm-fb Differential Revision: D56538909
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D56538909 |
r-barnes
force-pushed
the
export-D56538909
branch
from
3c82607 to
7f1f97c
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D56538909 |
r-barnes
force-pushed
the
export-D56538909
branch
from
7f1f97c to
d974d51
Compare
r-barnes
added a commit
to r-barnes/presto
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: prestodb#23575 Per title #buildmore - Be thorough #buildsonlynotests - No runtime effects! - If you approve of this diff, please use the "Accept & Ship" button no-ig-test - Doesn't require Instagram testing. (1 file modified.) Reviewed By: dmm-fb Differential Revision: D56538909
r-barnes
added a commit
to r-barnes/presto
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: prestodb#23575 Per title #buildmore - Be thorough #buildsonlynotests - No runtime effects! - If you approve of this diff, please use the "Accept & Ship" button no-ig-test - Doesn't require Instagram testing. (1 file modified.) Reviewed By: dmm-fb Differential Revision: D56538909
r-barnes
force-pushed
the
export-D56538909
branch
from
d974d51 to
d6bf027
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D56538909 |
1 similar comment
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D56538909 |
r-barnes
added a commit
to r-barnes/presto
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: prestodb#23575 Per title #buildmore - Be thorough #buildsonlynotests - No runtime effects! - If you approve of this diff, please use the "Accept & Ship" button no-ig-test - Doesn't require Instagram testing. (1 file modified.) Reviewed By: dmm-fb Differential Revision: D56538909
r-barnes
force-pushed
the
export-D56538909
branch
from
d6bf027 to
d983f85
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D56538909 |
r-barnes
added a commit
to r-barnes/presto
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: prestodb#23575 Per title #buildmore - Be thorough #buildsonlynotests - No runtime effects! - If you approve of this diff, please use the "Accept & Ship" button no-ig-test - Doesn't require Instagram testing. (1 file modified.) Reviewed By: dmm-fb Differential Revision: D56538909
r-barnes
force-pushed
the
export-D56538909
branch
from
d983f85 to
1f55b52
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D56538909 |
r-barnes
added a commit
to r-barnes/presto
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: prestodb#23575 Per title #buildmore - Be thorough #buildsonlynotests - No runtime effects! - If you approve of this diff, please use the "Accept & Ship" button no-ig-test - Doesn't require Instagram testing. (1 file modified.) Reviewed By: dmm-fb Differential Revision: D56538909
r-barnes
force-pushed
the
export-D56538909
branch
from
1f55b52 to
735ebcd
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D56538909 |
r-barnes
added a commit
to r-barnes/presto
that referenced
this pull request
Sep 4, 2024
Summary: Pull Request resolved: prestodb#23575 Per title #buildmore - Be thorough #buildsonlynotests - No runtime effects! - If you approve of this diff, please use the "Accept & Ship" button no-ig-test - Doesn't require Instagram testing. (1 file modified.) Reviewed By: dmm-fb Differential Revision: D56538909
r-barnes
force-pushed
the
export-D56538909
branch
from
735ebcd to
d253a7b
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D56538909 |
r-barnes
added a commit
to r-barnes/presto
that referenced
this pull request
Sep 4, 2024
Summary: Pull Request resolved: prestodb#23575 Per title #buildmore - Be thorough #buildsonlynotests - No runtime effects! - If you approve of this diff, please use the "Accept & Ship" button no-ig-test - Doesn't require Instagram testing. (1 file modified.) Reviewed By: dmm-fb Differential Revision: D56538909
r-barnes
force-pushed
the
export-D56538909
branch
from
d253a7b to
b217e7d
Compare
Contributor
|
I think -Wheader-hygiene is an internal concept? Can you change the PR title/description and commit message title/description to be clearer about what this is doing and why. It sounds like what this is doing is removing "using namespace xxx" from header files, as is aligned with our c++ codestyle guidelines, which follows the velox style guide https://github.com/facebookincubator/velox/blob/main/CODING_STYLE.md#namespaces. |
r-barnes
changed the title
-Wheader-hygiene for github/PACKAGE +1using namespace from header files
Contributor
Author
|
@rschlussel - I've made the requested updates. |
Contributor
|
Can you update the commit message as well (same description/title as the pr description)? |
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D56538909 |
r-barnes
force-pushed
the
export-D56538909
branch
from
b217e7d to
c148c1b
Compare
rschlussel
approved these changes
Sep 5, 2024
Contributor
rschlussel
left a comment
rschlussel
left a comment
There was a problem hiding this comment.
thanks! I need someone from team-velox to approve @amitkdutta
Contributor
Author
|
@rschlussel - done |
Contributor
|
@r-barnes I think you need to split the presto part of this change out from the other part for your diff. |
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D56538909 |
r-barnes
added a commit
to r-barnes/presto
that referenced
this pull request
Sep 5, 2024
Summary: Pull Request resolved: prestodb#23575 Removes using namespace from header files to align with Velox C++ codestyle guidelines Reviewed By: dmm-fb Differential Revision: D56538909
r-barnes
force-pushed
the
export-D56538909
branch
from
c148c1b to
54ffe96
Compare
r-barnes
added a commit
to r-barnes/presto
that referenced
this pull request
Sep 5, 2024
Summary: Pull Request resolved: prestodb#23575 Removes using namespace from header files to align with Velox C++ codestyle guidelines Reviewed By: dmm-fb Differential Revision: D56538909
r-barnes
force-pushed
the
export-D56538909
branch
from
54ffe96 to
1572211
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D56538909 |
r-barnes
added a commit
to r-barnes/presto
that referenced
this pull request
Sep 5, 2024
Summary: Pull Request resolved: prestodb#23575 Removes using namespace from header files to align with Velox C++ codestyle guidelines Reviewed By: dmm-fb Differential Revision: D56538909
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D56538909 |
r-barnes
force-pushed
the
export-D56538909
branch
from
1572211 to
2d13dde
Compare
Summary: Pull Request resolved: prestodb#23575 Removes using namespace from header files to align with Velox C++ codestyle guidelines Reviewed By: dmm-fb Differential Revision: D56538909
r-barnes
force-pushed
the
export-D56538909
branch
from
2d13dde to
20f5423
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D56538909 |
Contributor
Author
|
@aditi-pandit - How do I merge? |
AbhijitKulkarni1
pushed a commit
to intel-staging/presto
that referenced
this pull request
Oct 1, 2024
Summary: Pull Request resolved: prestodb#23575 Removes using namespace from header files to align with Velox C++ codestyle guidelines Reviewed By: dmm-fb Differential Revision: D56538909
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
using namespacefrom header files to align with Velox C++ codestyle guidelines (link).