Skip to content

Comments

[native] Add a metric to track expected reduction of memory and minor fixes#23872

Merged
tanjialiang merged 1 commit intoprestodb:masterfrom
bikramSingh91:pushback
Oct 22, 2024
Merged

[native] Add a metric to track expected reduction of memory and minor fixes#23872
tanjialiang merged 1 commit intoprestodb:masterfrom
bikramSingh91:pushback

Conversation

@bikramSingh91
Copy link
Contributor

Summary:

  • Add a metric presto_cpp.memory_pushback_expected_reduction_bytes
    to track expected reduction in memory after a pushback attempt as
    this can be different from actual reduction due to other threads
    allocating simultaneously
  • Fix registeration of a pushback metric
  • Make periodicCb() API non-const to allow it to update internal
    state if required

@bikramSingh91 bikramSingh91 requested a review from a team as a code owner October 22, 2024 20:56
… fixes

Summary:
- Add a metric `presto_cpp.memory_pushback_expected_reduction_bytes`
to track expected reduction in memory after a pushback attempt as
this can be different from actual reduction due to other threads
allocating simultaneously
- Fix registeration of a pushback metric
- Make periodicCb() API non-const to allow it to update internal
state if required
@steveburnett
Copy link
Contributor

Consider adding doc to properties.rst or properties-session.rst as appropriate.

@bikramSingh91
Copy link
Contributor Author

Consider adding doc to properties.rst or properties-session.rst as appropriate.

@steveburnett Thank you for your review.
This only adds a metric but no properties. Is there a doc that keeps track of metrics instead that I need to update?

Copy link
Contributor

@tanjialiang tanjialiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@tanjialiang tanjialiang merged commit 6537485 into prestodb:master Oct 22, 2024
@jaystarshot jaystarshot mentioned this pull request Nov 1, 2024
25 tasks
@jaystarshot
Copy link
Member

Please consider adding release notes following our release notes guide - link.

Using below for now

Add a metric presto_cpp.memory_pushback_expected_reduction_bytes
to track expected reduction in memory after a pushback attempt. :pr:`23872` 

@steveburnett
Copy link
Contributor

Consider adding doc to properties.rst or properties-session.rst as appropriate.

@steveburnett Thank you for your review. This only adds a metric but no properties. Is there a doc that keeps track of metrics instead that I need to update?

Not that I am aware of.

@tdcmeehan tdcmeehan added the from:Meta PR from Meta label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:Meta PR from Meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants