[native] Add a metric to track expected reduction of memory and minor fixes#23872
Merged
tanjialiang merged 1 commit intoprestodb:masterfrom Oct 22, 2024
Merged
[native] Add a metric to track expected reduction of memory and minor fixes#23872tanjialiang merged 1 commit intoprestodb:masterfrom
tanjialiang merged 1 commit intoprestodb:masterfrom
Conversation
… fixes Summary: - Add a metric `presto_cpp.memory_pushback_expected_reduction_bytes` to track expected reduction in memory after a pushback attempt as this can be different from actual reduction due to other threads allocating simultaneously - Fix registeration of a pushback metric - Make periodicCb() API non-const to allow it to update internal state if required
6567748 to
a6d8689
Compare
Contributor
|
Consider adding doc to properties.rst or properties-session.rst as appropriate. |
Contributor
Author
@steveburnett Thank you for your review. |
25 tasks
Member
|
Please consider adding release notes following our release notes guide - link. Using below for now |
Contributor
Not that I am aware of. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
presto_cpp.memory_pushback_expected_reduction_bytesto track expected reduction in memory after a pushback attempt as
this can be different from actual reduction due to other threads
allocating simultaneously
state if required