[native] Make periodic cache flush incremental#23626
Merged
zacw7 merged 1 commit intoprestodb:masterfrom Sep 12, 2024
Merged
Conversation
Contributor
|
Suggest the following revision of the release note entry to follow the Order of Changes in the Release Notes Guidelines. Perhaps something like: Also suggest adding documentation for the new |
c1df974 to
a0586c3
Compare
steveburnett
previously approved these changes
Sep 11, 2024
Contributor
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull branch, local docs build, looks good. Thanks!
a0586c3 to
821f631
Compare
821f631 to
3e4ede0
Compare
steveburnett
previously approved these changes
Sep 11, 2024
Contributor
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, new local docs build, looks good. Thanks!
xiaoxmeng
previously approved these changes
Sep 12, 2024
3e4ede0 to
a5a960f
Compare
When flushing the in-memory cache to SSD, perform an incremental flush instead of saving everything forcefully. Additionally, explicit checkpointing is unnecessary, as it will automatically trigger when the written bytes exceed the checkpoint threshold and during shutdown.
a5a960f to
80e6035
Compare
xiaoxmeng
approved these changes
Sep 12, 2024
elharo
approved these changes
Sep 12, 2024
25 tasks
Contributor
|
Saved that user @zacw7 is from Meta |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When flushing the in-memory cache to SSD, perform an incremental flush instead of saving everything forcefully. Additionally, explicit checkpointing is unnecessary, as it will automatically trigger when the written bytes exceed the checkpoint threshold and during shutdown.