Add release notes for 0.286#21906
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Mar 15, 2024
Merged
Conversation
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 8e82ee4...fe38304.
|
Closed
Member
Author
steveburnett
requested changes
Feb 14, 2024
Contributor
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
First review
- add PR links in :pr:
#####format as suggested in Formatting topic of Release Note Guidelines - add some links to documentation, probably several more opportunities to add doc links throughout
- minor grammar changes following release note guidelines
I did not spend a lot of time in this first pass editing text of release note entry lines for content or clarity.
I plan to repeat this after the release note entries listed in "Missing Release Notes" have been added.
Member
Author
|
I will squash all commits before merging into the |
jaystarshot
reviewed
Feb 23, 2024
jaystarshot
reviewed
Feb 23, 2024
jaystarshot
reviewed
Feb 23, 2024
jaystarshot
reviewed
Feb 23, 2024
jaystarshot
reviewed
Feb 23, 2024
jaystarshot
reviewed
Feb 23, 2024
| * Fix serialized name for retriable QueryError property. | ||
| * Fix the compilation error of merge function for KHyperLogLog state. | ||
| * Fixed a bug in cte materialization which was causing incorrect plan generation in some cases. | ||
| * Fixed redis-provider-plugin docs which previously contained an incorrect file name for property loading, and included the HBO configurations for the coordinator. |
Member
There was a problem hiding this comment.
Suggested change
| * Fixed redis-provider-plugin docs which previously contained an incorrect file name for property loading, and included the HBO configurations for the coordinator. | |
| * Fix redis-provider-plugin docs to include the correct configuration properties and added documentation for coordinator HBO configurations. :pr:`21477` |
Contributor
There was a problem hiding this comment.
Accidentally and mistakenly made a minor edit to @jaystarshot's suggestion when I meant to edit my own comment. I think I changed it back correctly.
jaystarshot
reviewed
Feb 23, 2024
jaystarshot
reviewed
Feb 23, 2024
jaystarshot
reviewed
Feb 23, 2024
| _______________ | ||
| * Fix a bug for min_by/max_by for window function, where results are incorrect when the function specifies number of elements to keep and the window does not have “unbounded following” in the frame. | ||
| * Fix a potential bug in EXCEPT and INTERSECT queries. Do not prune unreferenced output in intersect and except nodes. :pr:`21343` | ||
| * Fix bug of pull lambda out optimizers when expressions pulled out are of type JoniRegexType or LikePatternType. |
Member
There was a problem hiding this comment.
Suggested change
| * Fix bug of pull lambda out optimizers when expressions pulled out are of type JoniRegexType or LikePatternType. | |
| * Fix a bug in PullUpExpressionInLambdaRules optimizer where expressions being extracted were of JoniRegexType or LikePatternType. :pr:`21407` |
jaystarshot
reviewed
Feb 23, 2024
jaystarshot
reviewed
Feb 23, 2024
jaystarshot
reviewed
Feb 23, 2024
jaystarshot
reviewed
Feb 23, 2024
| General Changes | ||
| _______________ | ||
| * Fix a bug for min_by/max_by for window function, where results are incorrect when the function specifies number of elements to keep and the window does not have “unbounded following” in the frame. | ||
| * Fix a potential bug in EXCEPT and INTERSECT queries. Do not prune unreferenced output in intersect and except nodes. :pr:`21343` |
Member
There was a problem hiding this comment.
Suggested change
| * Fix a potential bug in EXCEPT and INTERSECT queries. Do not prune unreferenced output in intersect and except nodes. :pr:`21343` | |
| * Fix a potential bug in EXCEPT and INTERSECT queries by not pruning unreferenced output for intersect and except nodes in the PruneUnreferencedOutputs rule. :pr:`21343` |
jaystarshot
reviewed
Feb 23, 2024
jaystarshot
reviewed
Feb 23, 2024
jaystarshot
reviewed
Feb 23, 2024
jaystarshot
reviewed
Feb 23, 2024
| Iceberg Changes | ||
| _______________ | ||
| * Add Iceberg Filter Pushdown Optimizer Rule for execution with Velox. | ||
| * Add ``iceberg.pushdown-filter-enabled`` config property to Iceberg Connector. This config property will control the behaviour of Filter Pushdown in the iceberg connector. |
Member
There was a problem hiding this comment.
Suggested change
| * Add ``iceberg.pushdown-filter-enabled`` config property to Iceberg Connector. This config property will control the behaviour of Filter Pushdown in the iceberg connector. | |
| * Add IcebergFilterPushdownOptimizer for with Presto native execution. This feature is configurable by the configuration property ``iceberg.pushdown-filter-enabled``. |
Please combine this and previous line into a unified line
jaystarshot
reviewed
Feb 23, 2024
| * Add a session property to skip hash precomputation for join when the input is table scan, and the hash is on a single big int and is not reused later. It's controlled by session property `skip_hash_generation_for_join_with_table_scan_input` and default to not enabled. | ||
| * Add an feature config property `khyperloglog-agg-group-limit` to set the maximum number of groups `khyperloglog_agg` can have. It will fail the query when the limit is exceeded. The default is 0 which means no limit. | ||
| * Add an feature config property `limit-khyperloglog-agg-group-number-enabled` to control whether to limit the number of groups for aggregation functions using KHyperLogLog state. | ||
| * Add an optimization to optimize queries which has equivalence check filter or constant assignments. Controlled by session property `rewrite_expression_with_constant_expression` and default to enabled. |
Member
There was a problem hiding this comment.
Suggested change
| * Add an optimization to optimize queries which has equivalence check filter or constant assignments. Controlled by session property `rewrite_expression_with_constant_expression` and default to enabled. | |
| * Introduced an optimization to improve queries featuring equivalence check filters or constant assignments. This is controlled by the session property `rewrite_expression_with_constant_expression`(enabled by default). |
jaystarshot
reviewed
Feb 23, 2024
Member
Found these in non extracted release notes, please take a look |
Member
|
Can probably skip Prestissimo on Spark since its beta |
Contributor
General and Iceberg topics look good, thanks! If we include Prestissimo on Spark (I read the other comment about maybe not because beta), how about this rephrasing? |
steveburnett
requested changes
Mar 6, 2024
Contributor
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
New review, in which I:
- endorsed in support many of @jaystarshot 's review comments
- resolved old unaddressed comments that I recreated new for this review (note: some of my new comments combine my old comments with @jaystarshot's later-added suggestions to the same text)
- some unaddressed comments of mine I feel should be addressed I left unresolved
- retested links
- tried to consistently apply the Formatting topic of the Release Notes Guidelines.
| * Fix a potential bug in EXCEPT and INTERSECT queries. Do not prune unreferenced output in intersect and except nodes. :pr:`21343` | ||
| * Fix bug of pull lambda out optimizers when expressions pulled out are of type JoniRegexType or LikePatternType. | ||
| * Fix lambda expression pull out optimizer so that it will be able to extract independent expressions from conditional expression. :pr:`21344` | ||
| * Fix serialized name for retriable QueryError property. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Fix serialized name for retriable QueryError property. | |
| * Fix an issue with the serialization of the retriable property in QueryError. :pr:`19741` |
| * Fix serialized name for retriable QueryError property. | ||
| * Fix the compilation error of merge function for KHyperLogLog state. | ||
| * Fixed a bug in cte materialization which was causing incorrect plan generation in some cases. | ||
| * Fixed redis-provider-plugin docs which previously contained an incorrect file name for property loading, and included the HBO configurations for the coordinator. |
Contributor
There was a problem hiding this comment.
Accidentally and mistakenly made a minor edit to @jaystarshot's suggestion when I meant to edit my own comment. I think I changed it back correctly.
Contributor
|
@majetideepak @jaystarshot can you incorporate these suggestions into the release notes PR? You can push into @wanglinsong 's branch. |
Member
|
You mean push to this PR? Its a fork branch and I don't think we can |
wanglinsong
commented
Mar 9, 2024
Member
Author
wanglinsong
left a comment
wanglinsong
left a comment
There was a problem hiding this comment.
update per reviews
| * Fix serialized name for retriable QueryError property. | ||
| * Fix the compilation error of merge function for KHyperLogLog state. | ||
| * Fixed a bug in cte materialization which was causing incorrect plan generation in some cases. | ||
| * Fixed redis-provider-plugin docs which previously contained an incorrect file name for property loading, and included the HBO configurations for the coordinator. |
Member
Author
I have updated PR per reviews. |
steveburnett
requested changes
Mar 11, 2024
Contributor
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
This looks much improved!
Added a couple of missing PR links, fixed formatting of a couple of existing PR links, deleted some lines that were redundant or irrelevant.
Verified all recommended changes with a local build of the documentation.
Member
^^ I think these are not added |
Contributor
Thanks @jaystarshot! I have added these entries to the release notes, committed the suggestions, then pulled the updated branch to do a final local build and check the entire document. I think it's good now. |
steveburnett
approved these changes
Mar 13, 2024
Contributor
There was a problem hiding this comment.
LGTM! (docs)
- At @wanglinsong's request I committed my suggestions.
- Added @jaystarshot's un-added entries and committed those suggestions.
- Pulled updated branch, local build, then made and committed a final text change relating to the Order of changes in the release notes guidelines.
- Repeated pull of updated branch and local build, then reviewed latest local build of the docs based on the current branch.
I think that as soon as the commits are squashed, and a codeowner approves in a review, that this PR can be merged. Thanks everyone!
tdcmeehan
approved these changes
Mar 15, 2024
tdcmeehan
force-pushed
the
release-notes-0.286
branch
from
c93e552 to
fe38304
Compare
Contributor
|
Squashed commits, will merge when build is green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing Release Notes
AbhijitKulkarni1
Ajay Gupte
Amit Dutta
Andrii Rosa
Arjun Gupta
Avinash Jain
Bikramjeet Vig
Changli Liu
Deepak Majeti
Jimmy Lu
Ke
Kevin Wilfong
Mahadevuni Naveen Kumar
Patrick Stuedi
Pratik Joseph Dabre
Reetika Agrawal
Richard Barnes
Tim Meehan
feilong-liu
ApproximateMostFrequentto use type annotations" #21712 Revert "RefactorApproximateMostFrequentto use type annotations" (Merged by: feilong-liu)jaystarshot
kedia,Akanksha
wypb
xiaoxmeng
Extracted Release Notes
rewrite_expression_with_constant_expressionand default to enabled.iceberg.pushdown-filter-enabledconfig property to Iceberg Connector. This config property will control the behaviour of Filter Pushdown in the iceberg connector.skip_hash_generation_for_join_with_table_scan_inputand default to not enabled.adaptive_partial_aggregationsession property to true.config.propertiesandjvm.config.rewrite_left_join_array_contains_to_equi_join.AS OFsyntax for Iceberg tables to return historical data.khyperloglog-agg-group-limitto set the maximum number of groupskhyperloglog_aggcan have. It will fail the query when the limit is exceeded. The default is 0 which means no limit."$path"which returns the file path containing the row."$data_sequence_number"which returns the Iceberg data sequence number of the file containing the row.iceberg.delete_as_join_pushdown_enabled.ConnectorPlanOptimizer.optimize.hive.s3.use-instance-credentials#21648 (Author: Jalpreet Singh Nanda (:imjalpreet)): Deprecate hive confighive.s3.use-instance-credentialshive.s3.use-instance-credentials. This config will be removed in the upcoming release (:issue:21633).limit-khyperloglog-agg-group-number-enabledto control whether to limit the number of groups for aggregation functions using KHyperLogLog state.All Commits
CAST" (Ajay George)java.lang.OutOfMemoryError: Compressed class space(Pramod)max_spill_bytesconfigurable in presto-on-spark (Shrinidhi Joshi)ApproximateMostFrequentto use type annotations" (feilong-liu)hive.s3.use-instance-credentials(Jalpreet Singh Nanda (:imjalpreet))hive.s3.use-instance-credentialsin hive docs (Jalpreet Singh Nanda (:imjalpreet))CAST(wangd)