Skip to content

Pass cat token for view definer mode#21685

Merged
jainxrohit merged 1 commit intoprestodb:masterfrom
jainxrohit:rj_view
Jan 12, 2024
Merged

Pass cat token for view definer mode#21685
jainxrohit merged 1 commit intoprestodb:masterfrom
jainxrohit:rj_view

Conversation

@jainxrohit
Copy link
Contributor

@jainxrohit jainxrohit commented Jan 12, 2024

Description

Currently, for view definer mode in Presto, extra credentials such as CAT tokens are not passed. This change ensures that all extra credentials are passed in the view definer mode.

Motivation and Context

Impact

User extra credentials such as CAT tokens would be leveraged for presto views definer mode.

Test Plan

Validated by deploying changes to a cluster.

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
== RELEASE NOTES ==

General Changes
* Pass extra credentials such as CAT tokens for definer mode in views.

@jainxrohit jainxrohit requested a review from a team as a code owner January 12, 2024 04:00
Copy link

@happytank happytank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Currently for view definer mode in Presto, extra credentials such as
CAT tokens are not passed. This change ensures that all extra
credentials are passed in the view definer mode.
@jainxrohit jainxrohit merged commit 6b9f680 into prestodb:master Jan 12, 2024
@wanglinsong wanglinsong mentioned this pull request Feb 12, 2024
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants