[native] Follow up on task watchdog#21809
Conversation
Yuhta
force-pushed
the
tasks/T175424805/D52921877
branch
4 times, most recently
from
7f73c49 to
e652265
Compare
There was a problem hiding this comment.
Can we just get cache and all the other components from PrestoServer?
There was a problem hiding this comment.
These are not public in PrestoServer, do we want to expose them?
presto-native-execution/presto_cpp/main/PeriodicTaskManager.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Those metrics should be COUNT or SUM?
There was a problem hiding this comment.
COUNT and SUM are for cumulative values, this is a gauge value (0 is a valid non-initial state) so can only be AVG.
There was a problem hiding this comment.
GAUGE has a separate type from opencensus open sourced from Google. Gauge value won't change until the next update. AVG here is the average value within a time window. I thought we want to how many times a particular type of events happens during a time range? Thanks!
Yuhta
force-pushed
the
tasks/T175424805/D52921877
branch
from
e652265 to
d0745dd
Compare
Yuhta
force-pushed
the
tasks/T175424805/D52921877
branch
3 times, most recently
from
f025eb3 to
a9ef10c
Compare
Yuhta
force-pushed
the
tasks/T175424805/D52921877
branch
from
a9ef10c to
4691386
Compare
3 participants
Follow up on #21783