Add comma for number in printed query plan#21486
Merged
feilong-liu merged 1 commit intoprestodb:masterfrom Dec 7, 2023
Merged
Conversation
kaikalur
approved these changes
Dec 5, 2023
Contributor
|
While we're on this subject, can we make a change to NOT have the PlanNodeId's outputed with a |
Contributor
Author
|
Contributor
My bad, this wasn't obvious to me! |
jaystarshot
approved these changes
Dec 7, 2023
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the printed plan, add comma in the number so that it's more readable, for example
from
rows: 15000 (1.86MB), cpu: 1948552.00, memory: 0.00, network: 1948552.00torows: 15,000 (1.86MB), cpu: 1,948,552.00, memory: 0.00, network: 1,948,552.00Motivation and Context
To debug a query, we often need to compare the output for each operator, however the current format is hard to read for big numbers. This will make it more readable.
Impact
Make the printed query plan more readable.
Test Plan
Run query end to end to verify the new format is expected.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.