[native pos] Wait for process termination#21770
Merged
arhimondr merged 1 commit intoprestodb:masterfrom Jan 24, 2024
Merged
Conversation
When process is terminated with core wait for termination
shrinidhijoshi
approved these changes
Jan 24, 2024
Collaborator
shrinidhijoshi
left a comment
There was a problem hiding this comment.
@arhimondr LGTM. Could you please update the release notes with property changes ?
mbasmanova
approved these changes
Jan 24, 2024
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When process is terminated with core wait for termination
Motivation and Context
When not waiting for termination Spark can schedule a next task while the native process is in a middle of writing coredump
Impact
Queries can potentially take longer to fail
Test Plan
CI
Contributor checklist
Release Notes