Skip to content

[native pos] Wait for process termination#21770

Merged
arhimondr merged 1 commit intoprestodb:masterfrom
arhimondr:wait-for-process-termination
Jan 24, 2024
Merged

[native pos] Wait for process termination#21770
arhimondr merged 1 commit intoprestodb:masterfrom
arhimondr:wait-for-process-termination

Conversation

@arhimondr
Copy link
Member

@arhimondr arhimondr commented Jan 24, 2024

Description

When process is terminated with core wait for termination

Motivation and Context

When not waiting for termination Spark can schedule a next task while the native process is in a middle of writing coredump

Impact

Queries can potentially take longer to fail

Test Plan

CI

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== RELEASE NOTES ==

Prestissimo on Spark

Deprecate `native-trigger-coredump-when-unresponsive-enabled` config property in favor of `native-terminate-with-core-when-unresponsive-enabled`

When process is terminated with core wait for termination
@arhimondr arhimondr requested review from a team and shrinidhijoshi as code owners January 24, 2024 15:17
@arhimondr arhimondr requested a review from presto-oss January 24, 2024 15:17
Copy link
Collaborator

@shrinidhijoshi shrinidhijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arhimondr LGTM. Could you please update the release notes with property changes ?

@arhimondr arhimondr merged commit 0907cd8 into prestodb:master Jan 24, 2024
@arhimondr arhimondr deleted the wait-for-process-termination branch January 24, 2024 17:58
@wanglinsong wanglinsong mentioned this pull request Feb 12, 2024
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants