Skip to content

Add Iceberg table register and unregister procedures#21335

Merged
ChunxuTang merged 1 commit intoprestodb:masterfrom
kiersten-stokes:iceberg-table-register
Jan 3, 2024
Merged

Add Iceberg table register and unregister procedures#21335
ChunxuTang merged 1 commit intoprestodb:masterfrom
kiersten-stokes:iceberg-table-register

Conversation

@kiersten-stokes
Copy link
Contributor

@kiersten-stokes kiersten-stokes commented Nov 7, 2023

Description

Adds two procedures for Iceberg tables: register_table and unregister_table, as well as documentation on how to invoke them.

toHiveColumns has been moved to IcebergUtil from HiveTableOperations. A function dropTableFromMetastore is also added that ensures that data/metadata isn't deleted in during 'unregister' for file-based metastores (mostly for testing purposes).

Motivation and Context

Fixes #20421

Impact

Two new procedures will be accessible to users

Test Plan

Tested manually and added dedicated unit tests and smoke tests.

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Iceberg Changes
* Add register and unregister procedures for Iceberg tables

@kiersten-stokes kiersten-stokes requested a review from a team as a code owner November 7, 2023 19:49
@github-actions
Copy link

github-actions bot commented Nov 7, 2023

Codenotify: Notifying subscribers in CODENOTIFY files for diff 003e9b9...d5cf0b4.

Notify File(s)
@steveburnett presto-docs/src/main/sphinx/connector/iceberg.rst

@kiersten-stokes kiersten-stokes added the iceberg Apache Iceberg related label Nov 7, 2023
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Copy link
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Some little comments.

@kiersten-stokes kiersten-stokes force-pushed the iceberg-table-register branch 2 times, most recently from 499a468 to f28d848 Compare December 20, 2023 02:07
@kiersten-stokes kiersten-stokes changed the title [WIP] Add Iceberg table register and unregister procedures Add Iceberg table register and unregister procedures Dec 20, 2023
@tdcmeehan tdcmeehan self-assigned this Dec 20, 2023
Copy link
Contributor

@tdcmeehan tdcmeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the extensive tests

@tdcmeehan
Copy link
Contributor

@kiersten-stokes please fix the merge conflict!

@ChunxuTang any other comments?

@kiersten-stokes
Copy link
Contributor Author

@kiersten-stokes please fix the merge conflict!

@tdcmeehan done!

Copy link
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the job.

@ChunxuTang
Copy link
Member

LGTM. @kiersten-stokes Thanks for the nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

iceberg Apache Iceberg related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the ability to register and unregister an Iceberg format table from the catalog

5 participants