Add Iceberg table register and unregister procedures#21335
Merged
ChunxuTang merged 1 commit intoprestodb:masterfrom Jan 3, 2024
Merged
Add Iceberg table register and unregister procedures#21335ChunxuTang merged 1 commit intoprestodb:masterfrom
ChunxuTang merged 1 commit intoprestodb:masterfrom
Conversation
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 003e9b9...d5cf0b4.
|
kiersten-stokes
commented
Nov 7, 2023
presto-iceberg/src/main/java/com/facebook/presto/iceberg/RegisterTableProcedure.java
Outdated
Show resolved
Hide resolved
tdcmeehan
reviewed
Nov 16, 2023
presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergHiveMetadata.java
Outdated
Show resolved
Hide resolved
presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergUtil.java
Outdated
Show resolved
Hide resolved
Member
hantangwangd
left a comment
There was a problem hiding this comment.
Overall looks good! Some little comments.
presto-iceberg/src/main/java/com/facebook/presto/iceberg/RegisterTableProcedure.java
Outdated
Show resolved
Hide resolved
ChunxuTang
reviewed
Nov 18, 2023
presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergHiveMetadata.java
Outdated
Show resolved
Hide resolved
499a468 to
f28d848
Compare
tdcmeehan
approved these changes
Jan 2, 2024
Contributor
tdcmeehan
left a comment
There was a problem hiding this comment.
Thank you for the extensive tests
Contributor
|
@kiersten-stokes please fix the merge conflict! @ChunxuTang any other comments? |
f28d848 to
d5cf0b4
Compare
Contributor
Author
@tdcmeehan done! |
hantangwangd
approved these changes
Jan 2, 2024
Member
hantangwangd
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the job.
Member
|
LGTM. @kiersten-stokes Thanks for the nice work! |
ChunxuTang
approved these changes
Jan 3, 2024
64 tasks
This was referenced Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds two procedures for Iceberg tables:
register_tableandunregister_table, as well as documentation on how to invoke them.toHiveColumnshas been moved toIcebergUtilfromHiveTableOperations. A functiondropTableFromMetastoreis also added that ensures that data/metadata isn't deleted in during 'unregister' for file-based metastores (mostly for testing purposes).Motivation and Context
Fixes #20421
Impact
Two new procedures will be accessible to users
Test Plan
Tested manually and added dedicated unit tests and smoke tests.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.