Skip to content

Support year/month/day/hour transform when add partition column in Iceberg#21575

Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom
hantangwangd:iceberg_add_partition_column
Dec 20, 2023
Merged

Support year/month/day/hour transform when add partition column in Iceberg#21575
tdcmeehan merged 1 commit intoprestodb:masterfrom
hantangwangd:iceberg_add_partition_column

Conversation

@hantangwangd
Copy link
Member

@hantangwangd hantangwangd commented Dec 20, 2023

Description

As we have supported year, month, day & hour transform for Iceberg table when creating in PR #21303 , we could also support year, month, day & hour transform when altering table to add a partition column.

Impact

  • Presto Iceberg connector will support these partition transform functions when altering table to add partition columns.

Test Plan

  • Enhanced test case in IcebergDistributedTestBase.testAddPartitionColumn()

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== RELEASE NOTES ==


Iceberg Changes
* Day, Month, Year & Hour partition column transform functions are supported when altering table to add columns in Presto Iceberg connector.

@hantangwangd hantangwangd requested a review from a team as a code owner December 20, 2023 03:06
@github-actions
Copy link

Codenotify: Notifying subscribers in CODENOTIFY files for diff 0bf0549...c8c19d8.

Notify File(s)
@steveburnett presto-docs/src/main/sphinx/connector/iceberg.rst

@tdcmeehan tdcmeehan self-assigned this Dec 20, 2023
@tdcmeehan tdcmeehan merged commit f60635e into prestodb:master Dec 20, 2023
@hantangwangd hantangwangd deleted the iceberg_add_partition_column branch December 26, 2023 05:23
@wanglinsong wanglinsong mentioned this pull request Feb 12, 2024
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants