[native] Add non-blocking shuffle reader interface#21419
Merged
arhimondr merged 1 commit intoprestodb:masterfrom Jan 22, 2024
Merged
[native] Add non-blocking shuffle reader interface#21419arhimondr merged 1 commit intoprestodb:masterfrom
arhimondr merged 1 commit intoprestodb:masterfrom
Conversation
patrickstuedi
force-pushed
the
nonblocking-shuffle
branch
4 times, most recently
from
3aef69d to
0569776
Compare
patrickstuedi
force-pushed
the
nonblocking-shuffle
branch
2 times, most recently
from
9989481 to
4dd9ad8
Compare
yingsu00
reviewed
Dec 20, 2023
presto-native-execution/presto_cpp/main/operators/LocalPersistentShuffle.cpp
Outdated
Show resolved
Hide resolved
xiaoxmeng
approved these changes
Dec 27, 2023
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@patrickstuedi LGTM % nits. Thanks!
Contributor
There was a problem hiding this comment.
Move mutex_ ahead of its protected fields? Thanks!
presto-native-execution/presto_cpp/main/operators/UnsafeRowExchangeSource.cpp
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/operators/UnsafeRowExchangeSource.cpp
Outdated
Show resolved
Hide resolved
patrickstuedi
force-pushed
the
nonblocking-shuffle
branch
2 times, most recently
from
646d2d0 to
7d3ed09
Compare
xiaoxmeng
approved these changes
Dec 29, 2023
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@patrickstuedi thanks for the update!
patrickstuedi
force-pushed
the
nonblocking-shuffle
branch
8 times, most recently
from
f87d183 to
b63ee6e
Compare
xiaoxmeng
approved these changes
Jan 18, 2024
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@patrickstuedi LGTM % nit. Thanks!
Contributor
There was a problem hiding this comment.
return folly::makeSemiFuture<BufferPtr>(nullptr);
7d24cb2 to
cdd3e4a
Compare
Avoid blocking during shuffle read to support suspending of the shuffle operator.
patrickstuedi
force-pushed
the
nonblocking-shuffle
branch
from
cdd3e4a to
1a4dd64
Compare
xiaoxmeng
approved these changes
Jan 22, 2024
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@patrickstuedi LGTM. Thanks!
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid blocking during shuffle read to support suspending of the shuffle operator.