[native]Add to handle empty data case in ShuffleReader::next#21674
Merged
xiaoxmeng merged 1 commit intoprestodb:masterfrom Jan 11, 2024
Merged
[native]Add to handle empty data case in ShuffleReader::next#21674xiaoxmeng merged 1 commit intoprestodb:masterfrom
xiaoxmeng merged 1 commit intoprestodb:masterfrom
Conversation
mbasmanova
approved these changes
Jan 11, 2024
Contributor
mbasmanova
left a comment
mbasmanova
left a comment
There was a problem hiding this comment.
Thanks. Please add [native] prefix to commit and PR titles.
Add to handle empty data case in ShuffleReader::next and update UnsafeRowExchangeSource to remove the use of hasNext(). The followup is to deprecate hasNext.
xiaoxmeng
changed the title
tanjialiang
approved these changes
Jan 11, 2024
amitkdutta
approved these changes
Jan 11, 2024
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add to handle empty data case in ShuffleReader::next and update UnsafeRowExchangeSource
to remove the use of hasNext(). The followup is to deprecate hasNext.