Skip to content

Comments

[native]Add server memory pushback configs#21417

Merged
amitkdutta merged 1 commit intoprestodb:masterfrom
xiaoxmeng:stats
Nov 19, 2023
Merged

[native]Add server memory pushback configs#21417
amitkdutta merged 1 commit intoprestodb:masterfrom
xiaoxmeng:stats

Conversation

@xiaoxmeng
Copy link
Contributor

@xiaoxmeng xiaoxmeng commented Nov 18, 2023

Add server memory pushback configs:

  • system-mem-pushback-enabled is set to enable or disable server memory pushback
  • system-mem-limit-gb specifies the server memory limit to trigger server memory pushback
  • system-mem-shrink-gb specifies the memory to shrink when server memory pushback is
  • triggered.

Server memory pushback is reclaim server memory usage to help get the server out of memory
condition. Since getting the server memory is platform dependent, the actual low memory
condition detection can be implemented by deriving presto server's addAdditionalPeriodicTasks
to add a periodic running task to detect and trigger server memory pushback.
And we can reclaim memory by shrinking the async data cache: AsyncDataCache::shrink

@xiaoxmeng xiaoxmeng marked this pull request as ready for review November 18, 2023 21:33
@xiaoxmeng xiaoxmeng requested a review from a team as a code owner November 18, 2023 21:33
Add server memory pushback configs:

system-mem-pushback-enabled is set to enable or disable server memory pushback
system-mem-limit-gb specifies the server memory limit to trigger server memory pushback
system-mem-shrink-gb specifies the memory to shrink when server memory pushback is
triggered.
Server memory pushback is reclaim server memory usage to help get the server out of memory
condition. Since getting the server memory is platform dependent, the actual low memory
condition detection can be implemented by deriving presto server's addAdditionalPeriodicTasks
to add a periodic running task to detect and trigger server memory pushback.
And we can reclaim memory by shrinking the async data cache: AsyncDataCache::shrink
Copy link
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xiaoxmeng

@amitkdutta amitkdutta merged commit d86205c into prestodb:master Nov 19, 2023
@xiaoxmeng xiaoxmeng deleted the stats branch January 26, 2024 08:02
@wanglinsong wanglinsong mentioned this pull request Feb 12, 2024
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants