Skip to content

Remove unnecessary condition else check#21423

Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom
Akanksha-kedia:else
Dec 1, 2023
Merged

Remove unnecessary condition else check#21423
tdcmeehan merged 1 commit intoprestodb:masterfrom
Akanksha-kedia:else

Conversation

@Akanksha-kedia
Copy link
Contributor

@Akanksha-kedia Akanksha-kedia commented Nov 20, 2023

Description

Eliminate unneeded else condition check

Motivation and Context

Streamlining and eliminating superfluous if-else conditions.

Impact

No impact, just removal of extraneous elements.

Test Plan

Execute unit tests in presto-main and verify castToTimestamp and castToTime scenarios.

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Remove unnecessary condition else check

@Akanksha-kedia Akanksha-kedia requested a review from a team as a code owner November 20, 2023 11:09
@Akanksha-kedia Akanksha-kedia force-pushed the else branch 2 times, most recently from ab7ae19 to b80863a Compare November 21, 2023 06:27
@Akanksha-kedia
Copy link
Contributor Author

2023-11-21T00:20:32.223-0600 WARN TestNG-test=Surefire test-1 org.eclipse.jetty.util.thread.QueuedThreadPool QueuedThreadPool[http-worker]@5fbaf2de{STOPPING,2<=20<=200,i=0,q=12}[org.eclipse.jetty.util.thread.TryExecutor$$Lambda$280/1814466511@18707d06] Couldn't stop Thread[http-worker-59,5,main]
[INFO] Tests run: 158, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 373.087 s - in com.facebook.presto.hive.TestHiveDistributedJoinQueries
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 158, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

@Akanksha-kedia
Copy link
Contributor Author

2023-11-21T00:58:06.843-0600 WARN TestNG-test=Surefire test-1 com.facebook.presto.testng.services.LogTestDurationListener Tests from com.facebook.presto.verifier.framework.TestDataVerification took 1.88m
[INFO] Tests run: 180, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 236.171 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 180, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 04:38 min

@Akanksha-kedia
Copy link
Contributor Author

@tdcmeehan please review

@Akanksha-kedia
Copy link
Contributor Author

@tdcmeehan please helpt o review

@tdcmeehan tdcmeehan merged commit a3946f5 into prestodb:master Dec 1, 2023
@wanglinsong wanglinsong mentioned this pull request Feb 12, 2024
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants