Add UPDATE sql support in Presto Engine#21435
Conversation
f0fd9c6 to
b74d0d4
Compare
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff e2e22b3...c4b715f.
|
steveburnett
left a comment
There was a problem hiding this comment.
This is great doc, thanks!
I made some rephrasing and formatting suggestions, some of which are only suggestions for you to consider if you think they help. As always, if I've misunderstood your meaning, help me understand and we will find a solution.
(Oh, there are no comments about sql/update.rst because I didn't have anything to say about that file. I'm just mentioning it here to say that I didn't miss it :) ).
yingsu00
left a comment
There was a problem hiding this comment.
@agrawaldevesh Was this ported from Trino? If yes can you please add link to the Trino commit/PR?
There was a problem hiding this comment.
nit: add empty line above
|
@agrawalreetika There are test failures |
a8581db to
3bac874
Compare
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Thanks!
|
@yingsu00, I had added Trino commit in the commit message, I have now added it to PR description as well. |
presto-spi/pom.xml
Outdated
There was a problem hiding this comment.
It is required to resolve imports in UpdateNode Class
There was a problem hiding this comment.
@agrawalreetika I just realized you added the UpdateNode in SPI. I think it should be in com.facebook.presto.sql.planner.plan package, not the com.facebook.presto.spi.plan package. It should be the same as where DeleteNode is. com.facebook.presto.sql.planner.plan is for the plan nodes that are invisible to connectors and not modifiable by the connectors. Iceberg connector is not supposed to modify this PlanNode.
There was a problem hiding this comment.
Yes @yingsu00, I noticed this refactor was done in Presto. So I have also moved UpdateNode as well in same presto-main module itself.
Cherry-pick of trinodb/trino@af17e51 Co-authored-by: djsstarburst
3bac874 to
c4b715f
Compare
|
Reetika, UpdatablePageSource was removed in trinodb/trino#15161. Will you be able to check if it's applicable to Presto? Iceberg does not use this page source. |
Description
Add UPDATE SQL support in Presto Engine.
PR also includes new developer documentation which has details about how it works
Cherry-pick of trinodb/trino@af17e51
Motivation and Context
#20571
Impact
Test Plan
Contributor checklist
Release Notes