[native] Add http request active check when fetch data from output buffer manager#21780
Merged
xiaoxmeng merged 2 commits intoprestodb:masterfrom Jan 26, 2024
Merged
[native] Add http request active check when fetch data from output buffer manager#21780xiaoxmeng merged 2 commits intoprestodb:masterfrom
xiaoxmeng merged 2 commits intoprestodb:masterfrom
Conversation
Collaborator
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
force-pushed
the
scale1
branch
2 times, most recently
from
be750d6 to
ddeeb3a
Compare
xiaoxmeng
changed the title
xiaoxmeng
force-pushed
the
scale1
branch
4 times, most recently
from
a352bca to
6179ffa
Compare
xiaoxmeng
changed the title
mbasmanova
approved these changes
Jan 26, 2024
Contributor
mbasmanova
left a comment
mbasmanova
left a comment
There was a problem hiding this comment.
Thanks. Please, extract "Advance Velox" changes into a separate commit before merging.
…ffer manager Add http request active check when fetch data from output buffer manager in Velox. The active check is based on whether the http callstate has been destroyed or the associated request has expired. This is to avoid arbitrary output buffer to load data into a destination buffer which has set notify but the associated client request has expired. This helps to accelerate the shuffle for query with scale writer which uses arbitrary output buffer. Unit test is added to verify this behavior.
tanjialiang
approved these changes
Jan 26, 2024
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add http request active check when fetch data from output buffer manager
in Velox. The active check is based on whether the http callstate has been destroyed
or the associated request has expired. This is to avoid arbitrary output buffer
to load data into a destination buffer which has set notify but the associated client
request has expired. This helps to accelerate the shuffle for query with scale writer
which uses arbitrary output buffer.
Unit test is added to verify this behavior.