Skip to content

[native]Add hook to stop additional periodic task#21433

Merged
xiaoxmeng merged 1 commit intoprestodb:masterfrom
xiaoxmeng:delete
Nov 22, 2023
Merged

[native]Add hook to stop additional periodic task#21433
xiaoxmeng merged 1 commit intoprestodb:masterfrom
xiaoxmeng:delete

Conversation

@xiaoxmeng
Copy link
Contributor

No description provided.

@xiaoxmeng xiaoxmeng marked this pull request as ready for review November 21, 2023 22:15
@xiaoxmeng xiaoxmeng requested a review from a team as a code owner November 21, 2023 22:15
Add hook to stop additional periodic task and also
disable spilling collection for velox code refactor
@xiaoxmeng xiaoxmeng changed the title [native]Disable spilling stats collection [native]Add hook to stop additional periodic task Nov 21, 2023
Copy link
Contributor

@gggrace14 gggrace14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with it functionally. However why not remove the code for now and revert the change once we need it again?

@xiaoxmeng
Copy link
Contributor Author

I'm okay with it functionally. However why not remove the code for now and revert the change once we need it again?

We will add back stats things to ease the migration. Thanks!

@xiaoxmeng xiaoxmeng merged commit fe61466 into prestodb:master Nov 22, 2023
@wanglinsong wanglinsong mentioned this pull request Feb 12, 2024
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants