[native]Set cpu driver slicing to 1 second in Prestissimo#21643
Merged
xiaoxmeng merged 1 commit intoprestodb:masterfrom Jan 13, 2024
Merged
[native]Set cpu driver slicing to 1 second in Prestissimo#21643xiaoxmeng merged 1 commit intoprestodb:masterfrom
xiaoxmeng merged 1 commit intoprestodb:masterfrom
Conversation
We will remove this once Velox has default 1 second settings
gggrace14
reviewed
Jan 5, 2024
Contributor
gggrace14
left a comment
gggrace14
left a comment
There was a problem hiding this comment.
This change itself looks good to me that turns it on for Prestissimo.
It looks to me perf impactful. Can you help do a before & after perf comparison with prod traffic? Usually we compare total_split_cpu_time and query_execution_time.
Also just to get the knowledge, we once have this facebookincubator/velox#4620. How are the two related and different?
gggrace14
approved these changes
Jan 5, 2024
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will remove this once Velox has default 1 second settings