Apply INCREASE_CONTAINER_SIZE execution strategy for user supplied error codes#21513
Merged
pgupta2 merged 1 commit intoprestodb:masterfrom Dec 12, 2023
Merged
Conversation
pgupta2
force-pushed
the
retry_increased_container_error_codes
branch
from
6b6e680 to
ad382a7
Compare
singcha
reviewed
Dec 11, 2023
presto-spark-base/src/main/java/com/facebook/presto/spark/util/PrestoSparkFailureUtils.java
Outdated
Show resolved
Hide resolved
pgupta2
force-pushed
the
retry_increased_container_error_codes
branch
2 times, most recently
from
212acf7 to
03b6f71
Compare
singcha
approved these changes
Dec 11, 2023
Contributor
singcha
left a comment
singcha
left a comment
There was a problem hiding this comment.
Thanks for updating the PR.
pgupta2
force-pushed
the
retry_increased_container_error_codes
branch
from
03b6f71 to
dda3e56
Compare
NikhilCollooru
approved these changes
Dec 12, 2023
presto-spark-base/src/main/java/com/facebook/presto/spark/PrestoSparkSessionProperties.java
Outdated
Show resolved
Hide resolved
shrinidhijoshi
approved these changes
Dec 12, 2023
pgupta2
force-pushed
the
retry_increased_container_error_codes
branch
from
dda3e56 to
78dd8c3
Compare
pgupta2
force-pushed
the
retry_increased_container_error_codes
branch
from
78dd8c3 to
c166b05
Compare
pgupta2
requested review from
shrinidhijoshi
and removed request for
arhimondr and
presto-oss
shrinidhijoshi
approved these changes
Dec 12, 2023
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INCREASE_CONTAINER_SIZE execution strategy is quite generic
and can be applied to multiple error codes. Adding a session
property to pass a string of comma separated error_codes which
should be retried with this execution strategy.