Fix serialized name for retriable QueryError property#19741
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Dec 21, 2023
MasterOdin:retriable-property
Merged
Fix serialized name for retriable QueryError property#19741tdcmeehan merged 1 commit intoprestodb:masterfrom MasterOdin:retriable-property
tdcmeehan merged 1 commit intoprestodb:masterfrom
MasterOdin:retriable-property
Conversation
jaystarshot
approved these changes
May 26, 2023
tdcmeehan
approved these changes
Sep 11, 2023
Contributor
tdcmeehan
left a comment
tdcmeehan
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
Contributor
|
Please rebase to kick off latest tests. I'll merge when finished. |
Contributor
Author
|
@tdcmeehan Done! |
Contributor
Author
|
@tdcmeehan I've rebased again. Looking at the test failures, I'm not sure why they would fail, as they appear to be unrelated to my change. |
6 tasks
Fixes a bug where the retriable property for QueryError was being serialized to the string "boolean".
Contributor
|
Rebased again, should fix the errors. Will merge once tests pass. |
Contributor
|
Thanks once again @MasterOdin |
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan - Added unit test in
presto-client/src/test/java/com/facebook/presto/client/TestQueryError.java