Add validation that checks next URI host and port does not change during query execution#21101
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Dec 23, 2023
Merged
Conversation
…uring query execution
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 01c962e...95bf5b0.
|
|
Hi. |
Contributor
|
@skairali any further comments? |
|
@tdcmeehan @skairali any updates or some sort of rough ETA? |
tdcmeehan
approved these changes
Dec 23, 2023
|
@tdcmeehan can you confirm in which presto-jdbc GA version this fix is available? |
Contributor
|
This will go out in 0.286 (February/March timeframe) |
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Presto client can attempt to follow a next URI from an untrusted source, adding option to validate that next URI host and port does not change during query execution.
Motivation and Context
Presto clients can attempt to follow a next URI from an untrusted source, adding option to validate that the host and port are consistent during query execution as a security improvement.
Fixes advisory GHSA-86q5-qcjc-7pv4
Impact
Adding option to Presto Client to validate next URI during query execution. This is an opt in, by default the current client behavior does not change
Test Plan
Tested locally with CLI and Presto Jdbc client by sending an invalid next URI host & port during a query execution, confirmed clients will not follow the invalid next URI if option to perform this validation is turned on.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.