[Native] Fix PartitionedOutputNode plan node id#21742
Merged
zacw7 merged 1 commit intoprestodb:masterfrom Jan 29, 2024
Merged
Conversation
Collaborator
Author
Steps to ReproduceSet up both environments locally:
Ran query in both environments: After the change |
db2730b to
3b22d2f
Compare
3b22d2f to
3ae8a30
Compare
3ae8a30 to
1aa3032
Compare
xiaoxmeng
approved these changes
Jan 29, 2024
Contributor
xiaoxmeng
left a comment
There was a problem hiding this comment.
@kewang1024 LGTM. Thanks!
presto-native-execution/presto_cpp/main/types/PrestoToVeloxQueryPlan.cpp
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/types/PrestoToVeloxQueryPlan.cpp
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/types/PrestoToVeloxQueryPlan.cpp
Outdated
Show resolved
Hide resolved
bb55a3b to
a1a9bfe
Compare
Presto doesn't have PartitionedOutputNode and assigns its source node's plan node id to PartitionedOutputOperator. so Presto UI is expecting PartitionedOutputOperator having same node id as its source operator. However, Velox has PartitionedOutputNode whose plan node is is set to "root". To comply with original assumption, fix partitionedOutputNode plan node id to be "root.<source plan node ID>" and parse them back to source plan node ID in task stats reporting. Issue: prestodb#21741
a1a9bfe to
7e20828
Compare
zacw7
approved these changes
Jan 29, 2024
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Presto doesn't have PartitionedOutputNode and assigns its source node's plan
node id to PartitionedOutputOperator.
so Presto UI is expecting PartitionedOutputOperator having same node id as its
source operator.
However, Velox has PartitionedOutputNode whose plan node is is set to "root".
To comply with original assumption, fix partitionedOutputNode plan node id to be
root.<source plan node ID>and parse them back to source plan node ID in taskstats reporting.
Fixes #21741