[native] Add memory reclaim stats to task runtime stats#21794
Merged
xiaoxmeng merged 1 commit intoprestodb:masterfrom Jan 26, 2024
Merged
[native] Add memory reclaim stats to task runtime stats#21794xiaoxmeng merged 1 commit intoprestodb:masterfrom
xiaoxmeng merged 1 commit intoprestodb:masterfrom
Conversation
mbasmanova
reviewed
Jan 26, 2024
Contributor
mbasmanova
left a comment
There was a problem hiding this comment.
@xiaoxmeng Thank you for adding this stat. Looks good % small comment.
Contributor
There was a problem hiding this comment.
It would be nice to report these stats live while query is running.
There is code later that calls processTaskStats which clears taskRuntimeStats if query is not running.
Also, I noticed that Coordinator UI shows stats based on unit. Hence, you need to specify kNanos unit to ensure nice display.
For example,
taskRuntimeStats.insert(
{"nativeProcessCpuTime",
RuntimeMetric(processCpuTime_, RuntimeCounter::Unit::kNanos)});
Contributor
Author
There was a problem hiding this comment.
You mean to call processTaskStats with tryToSkipIfRunning to false?
Add task runtime stats to collect memory reclaim stats during a task execution. This helps to debug how much time spent on task memory reclaim of a slow query execution. If the memory reclaim is triggered by the task itself, then the time will also be counted in task cpu execution time. If not, it is counted in the task's scheduled time but not execution time as the task will be stopped before memory reclamation.
tanjialiang
approved these changes
Jan 26, 2024
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add task runtime stats to collect memory reclaim stats during a task execution.
This helps to debug how much time spent on task memory reclaim of a slow query
execution. If the memory reclaim is triggered by the task itself, then the time will
also be counted in task cpu execution time. If not, it is counted in the task's scheduled
time but not execution time as the task will be stopped before memory reclamation.