Refactor assertCreateTableAsSelect() and assertExplainAnalyze() functions#21811
Merged
majetideepak merged 1 commit intoprestodb:masterfrom Feb 8, 2024
Merged
Refactor assertCreateTableAsSelect() and assertExplainAnalyze() functions#21811majetideepak merged 1 commit intoprestodb:masterfrom
majetideepak merged 1 commit intoprestodb:masterfrom
Conversation
|
|
pdabre12
changed the title
pdabre12
force-pushed
the
refactor-functions
branch
from
0bd9110 to
8b2725c
Compare
majetideepak
changed the title
pdabre12
force-pushed
the
refactor-functions
branch
from
8b2725c to
c054d03
Compare
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 0ddb2c1...c054d03. No notifications. |
tdcmeehan
approved these changes
Feb 8, 2024
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring the
assertCreateTableAsSelect()andassertExplainAnalyze()functions to live inAbstractTestQueryFrameWorkfor code re-usability.The goal is to use these for the NativeQueryRunner tests.