Fix writtenIntermediateBytes metric to capture correct intermediate w…

[jaystarshot]

The writtenIntermediateBytes metric was noop because plan.isOutputTableWriterFragment() will always be true and wrong metrics were updated when there are temporary table writes currently since there was a bug in plan Fragmenter where it would pass temporary tables' writer operator as output table writes hence populating the wrong metric.
code link.

Fixed by adding the information (whether temporary) to the tablewriterNode and filtering out those

Impact

Fixed writtenIntermediateBytes metric. Users of CTE and Exchange materialization should now be able to see the correct populated metric

Test Plan

Production tested

Contributor checklist

• Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Fixed writtenIntermediateBytes metric by ensuring its correct population through temporary table writers.

[jaystarshot]

Main fix

[jaystarshot]

Clone of the above function with a filter on the temporaryTableWriters

[feilong-liu]

where is this used?

[jaystarshot]

Removed thanks

[feilong-liu]

LGTM. I also briefly checked the code to make sure that the "outputTableWriterFragment" variable is only used for accounting purpose.

Can you maybe add a comment for the "outputTableWriterFragment" member in "PlanFragment" class stating that this is true only for final output fragment, but not for temporary table writer?

[jaystarshot]

cc: @tdcmeehan

[steveburnett]

Nit (commenting because it's not enough for a review): in Description, suggest deleting the lines in the release note entry after the line Fixed writtenIntermediateBytes metric...

[steveburnett]

Nit (commenting because it's not enough for a review): in Description, suggest deleting the lines in the release note entry after the line Fixed writtenIntermediateBytes metric...

Thanks!