[native]Advance velox and update memory part#21559
Merged
tanjialiang merged 1 commit intoprestodb:masterfrom Dec 19, 2023
Merged
[native]Advance velox and update memory part#21559tanjialiang merged 1 commit intoprestodb:masterfrom
tanjialiang merged 1 commit intoprestodb:masterfrom
Conversation
xiaoxmeng
force-pushed
the
new1
branch
7 times, most recently
from
ca69b2a to
ab409aa
Compare
aditi-pandit
approved these changes
Dec 18, 2023
xiaoxmeng
force-pushed
the
new1
branch
2 times, most recently
from
c975f29 to
0c73ba7
Compare
majetideepak
requested changes
Dec 19, 2023
Collaborator
majetideepak
left a comment
majetideepak
left a comment
There was a problem hiding this comment.
@xiaoxmeng can you please add a description of the changes to the commit?
It is not clear to me what deprecatedAddDefaultLeafMemoryPool does.
Thank you!
Contributor
Author
@majetideepak Updated. It is to be compatible with Meta internal code once the deprecated getInstance() is removed and |
majetideepak
approved these changes
Dec 19, 2023
Collaborator
majetideepak
left a comment
majetideepak
left a comment
There was a problem hiding this comment.
@xiaoxmeng Thanks! Please update the git commit description as well next time.
It's fine this time since this is a temporary change.
Update the memory management code based on velox side change. To ensure not breaking Meta internal build, we temporarily switch to use deprecated APIs instead of calling MemoryManager::getInstance() which currently has two versions
tanjialiang
approved these changes
Dec 19, 2023
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the memory management code based on velox side change.
To ensure not breaking Meta internal build, we temporarily switch to
use deprecated APIs instead of calling MemoryManager::getInstance()
which currently has two versions