Skip to content

Add Ecosystem and ORM to docs#21698

Merged
steveburnett merged 2 commits intoprestodb:masterfrom
TommyLemon:master
Feb 7, 2024
Merged

Add Ecosystem and ORM to docs#21698
steveburnett merged 2 commits intoprestodb:masterfrom
TommyLemon:master

Conversation

@TommyLemon
Copy link
Contributor

Description

Add Ecosystem to docs

Motivation and Context

Add links for ecosystem projects, to help users easily find what they need, and help the projects gain more impact.

Impact

No feature impact, no performance impact

Test Plan

View the web page of the docs

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Added 1 folder(ecosystem) and 1 file in sphinx
* Added 1 line in sphinx/index.rst

@TommyLemon TommyLemon requested a review from a team as a code owner January 14, 2024 15:23
@TommyLemon TommyLemon requested a review from presto-oss January 14, 2024 15:23
@TommyLemon TommyLemon mentioned this pull request Jan 14, 2024
6 tasks
@github-actions
Copy link

github-actions bot commented Jan 14, 2024

Codenotify: Notifying subscribers in CODENOTIFY files for diff 4ed9b52...f3923f5.

Notify File(s)
@steveburnett presto-docs/src/main/sphinx/ecosystem.rst
presto-docs/src/main/sphinx/ecosystem/list.rst
presto-docs/src/main/sphinx/index.rst

@github-actions github-actions bot added the docs label Jan 14, 2024
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull branch, made a new local build, looks okay.

@steveburnett
Copy link
Contributor

NOTE: because of PR 21708 today, to successfully build the branch locally for my review today I had to update my fork, git checkout master, git pull, checkout this branch, then git merge master to update presto-docs/requirements.txt in this branch.

After that, build succeeded. Without the updated requirements.txt, the presto-docs local build failed as described in PR 21708.

@TommyLemon
Copy link
Contributor Author

TommyLemon commented Feb 2, 2024

@tdcmeehan @steveburnett
another reviewer is requested to approve for merging this pr.
presto-oss and prestodb/committers are the options listed by the bot.

@steveburnett
Copy link
Contributor

Tests docs / test (:presto-docs) (pull_request) and maven checks / maven-checks (pull_request) are failing. When I build this doc locally I get the following error:

python3 -m sphinx -b html -n -d target/doctrees  -j auto src/main/sphinx target/html
Running Sphinx v4.4.0

Sphinx version error:
The sphinxcontrib.applehelp extension used by this project needs at least Sphinx v5.0; it therefore cannot be built with this version.
make: *** [html] Error 2

To successfully build the docs in this branch I run git merge master to update presto-docs/requirements.txt as described in PR 21708 in this branch, and then the build succeeds.

@TommyLemon, if you could update this branch, squashing merge commits as usual, I think that would pull in the change in PR 21708 and allow the failing tests to pass.

@steveburnett steveburnett merged commit b60d697 into prestodb:master Feb 7, 2024
@wanglinsong wanglinsong mentioned this pull request Feb 12, 2024
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants