Fix sign shift issue in presto#21884
Merged
spershin merged 1 commit intoprestodb:masterfrom Feb 8, 2024
Merged
Conversation
Differential Revision: D53577764
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D53577764 |
spershin
approved these changes
Feb 8, 2024
| static const char* kMap = "MAP"; | ||
| static const char* kInt128Array = "INT128_ARRAY"; | ||
| static const __int128_t kInt128Mask = ~(static_cast<__int128_t>(1) << 127); | ||
| static const __uint128_t kInt128Mask = ~(static_cast<__uint128_t>(1) << 127); |
Contributor
There was a problem hiding this comment.
Interesting that velox/type/DecimalUtil.h
has
static constexpr uint128_t kInt128Mask = (static_cast<uint128_t>(1) << 127);
And it is not really used anywhere.
I think presto_cpp should maybe use that Velox's constant.
But let's merge this one for now to move fast.
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D53577764