Separate CTE materialization session Properties from exchange Materialization

[jaystarshot]

1. Enchances control of cte materialization hash partition buckets. Previously same property as exchanges were used

Current testing has shown that recommended value is 4x but further performance testing might be needed.

Meta recommends setting hash partition for materialized exchange as 5X - 10X the cluster size in exchange materialization and we do not want that as the hash partition count of non materialized exchanges

https://prestodb.io/docs/current/admin/exchange-materialization.html#using-exchange-materialization

2. Separates cte_partitioning_provider_catalog from exchange materialization

This is needed since its good separation between features since these are cross used

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

• Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Added CTE hash partition count session property

[jaystarshot]

Updated CTE tests to use the new property

[steveburnett]

Could documentation for this new session property be added? Possibly in Properties Reference.

[github-actions]

Codenotify: Notifying subscribers in CODENOTIFY files for diff 00faa91...ab406a4.

Notify	File(s)
@steveburnett	presto-docs/src/main/sphinx/admin/properties.rst

[steveburnett]

Thanks for the documentation! One nit only.

[steveburnett]

Suggested change

	This setting determines how many buckets/writers should be used when materializing the CTEs, potentially affecting the performance of queries involving CTE materialization.
	This setting determines how many buckets or writers should be used when materializing the CTEs, potentially affecting the performance of queries involving CTE materialization.

Avoid slashes. See GitLab doc recommended word list entry for slashes for advice and suggestions.

[jaystarshot]

Added the docs, but isn't this page redundant since we already have @ConfigDescription? Does it make more sense to add @ConfigDescription to all new session properties and pull them in the docs page during releases?

[steveburnett]

LGTM@ (docs)

Pull branch, local build, docs look great. Thanks!

[steveburnett]

Added the docs, but isn't this page redundant since we already have @ConfigDescription? Does it make more sense to add @ConfigDescription to all new session properties and pull them in the docs page during releases?

That's a great idea! I'll look into this possibility for generating the docs. Thanks very much for bringing it up.

[jaystarshot]

@steveburnett Added documentation for cte-materialization-strategy property, please review

[steveburnett]

LGTM! (docs)

Pull branch, local build of docs, looks good. Thanks!

[tdcmeehan]

LGTM % nit on the first commit, and please also add session property documentation.

Please make sure it follows our guidelines. Suggested:

Add cte_hash_partition_count and config property
This commit adds the `cte_hash_partition_count`, and corresponding config property `query.cte-hash-partition-count`, which controls number of writers for CTE materialization effectively

[steveburnett]

Took another look, two minor suggestions.

[steveburnett]

The tiniest of nits.

[steveburnett]

LGTM! (docs)

Pull branch, local build of docs.