[native] Add system memory check configs#21463
Merged
xiaoxmeng merged 1 commit intoprestodb:masterfrom Dec 7, 2023
Merged
Conversation
xiaoxmeng
reviewed
Nov 30, 2023
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@bikramSingh91 LGTM % minors. Thanks!
bikramSingh91
force-pushed
the
add_configs_mem_check
branch
from
2471857 to
818505d
Compare
bikramSingh91
force-pushed
the
add_configs_mem_check
branch
from
818505d to
7f86264
Compare
xiaoxmeng
approved these changes
Dec 4, 2023
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@bikramSingh91 LGTM. Thanks!
bikramSingh91
force-pushed
the
add_configs_mem_check
branch
3 times, most recently
from
6907c78 to
a0e18c2
Compare
xiaoxmeng
approved these changes
Dec 6, 2023
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@bikramSingh91 thanks for the update!
Configs added: "malloc-mem-heap-dump-enabled" is set to enable or disable periodic malloc memory usage checks and dump heap profile if usage exceeds a certain threshold. "malloc-heap-dump-threshold-gb" the threshold in GigaBytes of memory allocated via malloc, above which a heap dump will be triggered. "malloc-mem-min-heap-dump-interval" specifies the time interval in seconds between consecutive memory heap dumps if usage stays above threshold "malloc-mem-max-heap-dump-files" specifies the max number of latest heap profiles to keep. These can be used to implement a malloc memory checking mechanism that periodically checks memory allocated via malloc and triggers actions like dumping heap profiles if the usage exceeds a certain limit. This can be used as an effective debugging tool for understanding where the excessive usage is allocated.
bikramSingh91
force-pushed
the
add_configs_mem_check
branch
from
a0e18c2 to
7edb8f1
Compare
xiaoxmeng
approved these changes
Dec 6, 2023
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configs added:
"malloc-mem-heap-dump-enabled" is set to enable or disable periodic
malloc memory usage checks and dump heap profile if usage exceeds a
certain threshold.
"malloc-heap-dump-threshold-gb" the threshold in GigaBytes of memory
allocated via malloc, above which a heap dump will be triggered.
"malloc-mem-min-heap-dump-interval" specifies the time interval in
seconds between consecutive memory heap dumps if usage stays above
threshold
"malloc-mem-max-heap-dump-files" specifies the max number of latest
heap profiles to keep.
These can be used to implement a malloc memory checking mechanism that
periodically checks memory allocated via malloc and triggers actions
like dumping heap profiles if the usage exceeds a certain limit.
This can be used as an effective debugging tool for understanding
where the excessive usage is allocated.