Add additional linear regression functions#21630
Conversation
|
Two things I wanted to mention:
|
tdcmeehan
left a comment
There was a problem hiding this comment.
It might be worthwhile to add a couple light utilities to reduce the duplication among the aggregation tests. Otherwise code LGTM>
There was a problem hiding this comment.
These methods all look nearly identical, can you create a utility method to consolidate?
There was a problem hiding this comment.
Thanks, updated. Some methods have been put into the abstract class.
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff e01dc52...bf2d675.
|
|
@steveburnett Thanks.
|
There was a problem hiding this comment.
| .. function:: regr_avgx(y, x) -> double | |
| .. function:: regr_avgx(y, x) -> double | |
There was a problem hiding this comment.
| .. function:: regr_avgy(y, x) -> double | |
| .. function:: regr_avgy(y, x) -> double | |
There was a problem hiding this comment.
| .. function:: regr_count(y, x) -> double | |
| .. function:: regr_count(y, x) -> double | |
There was a problem hiding this comment.
| .. function:: regr_r2(y, x) -> double | |
| .. function:: regr_r2(y, x) -> double | |
There was a problem hiding this comment.
| .. function:: regr_sxy(y, x) -> double | |
| .. function:: regr_sxy(y, x) -> double | |
There was a problem hiding this comment.
| .. function:: regr_syy(y, x) -> double | |
| .. function:: regr_syy(y, x) -> double | |
There was a problem hiding this comment.
| .. function:: regr_sxx(y, x) -> double | |
| .. function:: regr_sxx(y, x) -> double | |
There was a problem hiding this comment.
Thanks, Updated. Here's the new screenshot of what the doc build looks like:
Thanks! I just now did a new pull and local build of the doc and everything looks good! Updating my review to Approve for the docs.
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
New pull of branch and new local build of docs, everything looks good. Thanks!
tdcmeehan
left a comment
There was a problem hiding this comment.
LGTM. Please squash commits and I can help merge. Thank you!
7049eff to
e87bb19
Compare
|
@tdcmeehan Thanks, done. |
tdcmeehan
left a comment
There was a problem hiding this comment.
Changes look good, but please make sure the commit follows our guidelines.. Consider Add additional linear regression functions as a title and list out the functions in the body.
|
@tdcmeehan Updated the title and description. |
|
Thanks @8dukongjian, but I meant the commit message--the message in Git history. The link above describes this. |
Add REGR_AVGX, REGR_AVGY, REGR_COUNT, REGR_R2, REGR_SXX, REGR_SXY, and REGR_SYY.
e87bb19 to
bf2d675
Compare
|
@tdcmeehan Thanks, done. |


Description
Fix #21328
Add additional linear regression functions, include:
Release Notes
Please follow release notes guidelines and fill in the release notes below.