Skip to content

Fix bug that the specified kubeConfigPath in Piped config was not used while handling manifests #3410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pipecd-bot merged 2 commits into from
Mar 17, 2022
Merged

Fix bug that the specified kubeConfigPath in Piped config was not used while handling manifests #3410

pipecd-bot merged 2 commits into from
Mar 17, 2022

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Mar 17, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1946

Does this PR introduce a user-facing change?:

Fix bug that the specified kubeConfigPath in Piped config was not used while handling manifests

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Mar 17, 2022

COVERAGE

Code coverage for golang is 35.11%. This pull request decreases coverage by -0.41%.

File Function Base Head Diff
pkg/app/ops/insightcollector/collector.go NewCollector 0.00% 0.00% +0.00%
pkg/app/ops/insightcollector/collector.go Collector.Run 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/kubectl.go Kubectl.Apply 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/kubectl.go Kubectl.Create 0.00% 0.00% +0.00%
pkg/app/piped/executor/kubernetes/kubernetes.go deployExecutor.Execute 0.00% 0.00% +0.00%
pkg/insight/datapoint.go DeployFrequency.Merge 66.67% 0.00% -66.67%
pkg/insight/datapoint.go UpdateDataPoint 80.00% 0.00% -80.00%
pkg/insight/insightstore/chunkstore.go NewStore 100.00% 0.00% -100.00%
pkg/insight/datapoint.go ToDataPoints 90.00% 50.00% -40.00%
pkg/app/piped/cloudprovider/kubernetes/kubectl.go Kubectl.Replace 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/kubectl.go Kubectl.Delete 0.00% 0.00% +0.00%
pkg/app/piped/executor/kubernetes/rollback.go rollbackExecutor.ensureRollback 0.00% 0.00% +0.00%
pkg/insight/datapoint.go ChangeFailureRate.GetTimestamp 100.00% 0.00% -100.00%
pkg/app/server/grpcapi/web_api.go WebAPI.GetInsightData 0.00% 0.00% +0.00%
pkg/app/ops/insightcollector/collector.go Collector.collectDeploymentMetrics 0.00% -- +-0.00%
pkg/app/ops/insightcollector/collector.go Collector.processNewlyCreatedDeployments 0.00% -- +-0.00%
pkg/app/ops/insightcollector/collector.go Collector.processNewlyCompletedDeployments 0.00% -- +-0.00%
pkg/app/ops/insightcollector/deployments.go Collector.collectDeploymentChangeFailureRate 0.00% -- +-0.00%
pkg/app/ops/insightcollector/deployments.go Collector.collectDevelopmentFrequency 0.00% -- +-0.00%
pkg/app/ops/insightcollector/deployments.go Collector.findDeploymentsCreatedInRange 100.00% -- -100.00%
pkg/app/ops/insightcollector/deployments.go Collector.findDeploymentsCompletedInRange 100.00% -- -100.00%
pkg/app/ops/insightcollector/deployments.go Collector.updateApplicationChunks 0.00% -- +-0.00%
pkg/app/ops/insightcollector/deployments.go updateChunk 0.00% -- +-0.00%
pkg/app/ops/insightcollector/deployments.go updateDataPoints 76.92% -- -76.92%
pkg/app/ops/insightcollector/deployments.go extractDailyInsightDataPoints 94.44% -- -94.44%
pkg/app/ops/insightcollector/deployments.go extractDeployFrequency 100.00% -- -100.00%
pkg/app/ops/insightcollector/deployments.go extractChangeFailureRate 94.12% -- -94.12%
pkg/app/ops/insightcollector/deployments.go groupDeployments 100.00% -- -100.00%
pkg/insight/chunk.go DeployFrequencyChunk.GetFilePath 0.00% -- +-0.00%
pkg/insight/chunk.go DeployFrequencyChunk.SetFilePath 100.00% -- -100.00%
pkg/insight/chunk.go DeployFrequencyChunk.GetAccumulatedTo 0.00% -- +-0.00%
pkg/insight/chunk.go DeployFrequencyChunk.SetAccumulatedTo 100.00% -- -100.00%
pkg/insight/chunk.go DeployFrequencyChunk.GetDataPoints 83.33% -- -83.33%
pkg/insight/chunk.go DeployFrequencyChunk.SetDataPoints 90.00% -- -90.00%
pkg/insight/chunk.go ChangeFailureRateChunk.GetFilePath 0.00% -- +-0.00%
pkg/insight/chunk.go ChangeFailureRateChunk.SetFilePath 100.00% -- -100.00%
pkg/insight/chunk.go ChangeFailureRateChunk.GetAccumulatedTo 0.00% -- +-0.00%
pkg/insight/chunk.go ChangeFailureRateChunk.SetAccumulatedTo 100.00% -- -100.00%
pkg/insight/chunk.go ChangeFailureRateChunk.GetDataPoints 33.33% -- -33.33%
pkg/insight/chunk.go ChangeFailureRateChunk.SetDataPoints 60.00% -- -60.00%
pkg/insight/chunk.go NewChunk 0.00% -- +-0.00%
pkg/insight/chunk.go ToChunk 75.00% -- -75.00%
pkg/insight/chunk.go Chunks.ExtractDataPoints 68.75% -- -68.75%
pkg/insight/filepath.go MakeYearsFilePath 100.00% -- -100.00%
pkg/insight/filepath.go MakeChunkFilePath 100.00% -- -100.00%
pkg/insight/filepath.go DetermineFilePaths 90.00% -- -90.00%
pkg/insight/filepath.go determineChunkKeys 92.86% -- -92.86%
pkg/insight/insightstore/chunkstore.go store.LoadChunks 88.89% -- -88.89%
pkg/insight/insightstore/chunkstore.go store.PutChunk 0.00% -- +-0.00%
pkg/insight/insightstore/chunkstore.go LoadChunksFromCache 0.00% -- +-0.00%
pkg/insight/insightstore/chunkstore.go PutChunksToCache 0.00% -- +-0.00%
pkg/insight/insightstore/chunkstore.go store.getChunk 81.25% -- -81.25%
pkg/insight/utils.go NormalizeTime 100.00% -- -100.00%

@nghialv
Copy link
Member Author

nghialv commented Mar 17, 2022

/changelog

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Mar 17, 2022

CHANGELOG

@nghialv: Changelog has been generated in response to this comment.

Details

Changelog since v0.26.0

Notable Changes

  • Be able to show artifact versions for lambda deployment (#3390)
  • Be able to show artifact versions with links (#3382)
  • Move menu to be lower to avoid overlapping the tab bar. (#3332)
  • Show running version and documentation link on the web console (#3328)
  • Improve false positives when using Secret with stringData in Kubernetes App (#3299)
  • Fix a bug that previous plan-preview comments are not hidden if a customized bot name was used (#3327)
  • Allow filtering suggested applications by using a new appSelector field in Piped config (#3320)
  • Enable to view Application live state for Cloud Run (#3301)
  • Implement live state reporter for Cloud Run (#3284)

Internal Changes

  • Refactor kubernetes provider by separating Loader and Applier (#3407)
  • Change insight proto definition (#3403)
  • Simplify config by merge CloudProviderType with ApplicationKind (#3402)
  • Fix the name of CI jobs (#3404)
  • Define RBAC resource model (#3392)
  • Update contributor list (#3397)
  • Update contributor list (#3396)
  • Remarshal manifest to decrease false-positive (#3370)
  • Add filedb filter logic (#3389)
  • Add index to CompletedAt (#3388)
  • Run tests in parallel for pkg/app/piped (#3383)
  • Add id to condition (#3387)
  • Output artifact versions for ecs deployment (#3385)
  • Update commands related to web development in docs (#3381)
  • Move frontend code to the root directory (#3376)
  • Determine artifact version for Cloud Run (#3368)
  • Add build and test jobs for both backend and frontend (#3374)
  • Add missing context for docker build (#3372)
  • Start publishing all component images to GHC (#3371)
  • Fix wrong GitHub actions configuration (#3369)
  • Add experimental GitHub actions for CI jobs (#3367)
  • Add launcher_version to Piped metrics (#3365)
  • Update protoc-gen-validate to v0.6.6 (#3366)
  • Implement update interface for filedb (#3364)
  • Move launcher config to config package (#3362)
  • Fix bug that Launcher could not load the new format of Piped config (#3361)
  • Remove unused commands, scripts (#3360)
  • Switch to use code generated by codegen's protoc (#3355)
  • Use Go embed for static texts (#3359)
  • Use codegen to generate Go mock files (#3356)
  • Fix flaky tests (#3357)
  • Refresh generated code (#3353)
  • Update dependencies in codegen to latests (#3352)
  • Upgrade grpc-go and protobuf to latest versions (#3351)
  • Add ArtifactVersion to KubernetesApp Deployment (#3340)
  • Add an action to validate generated code (#3348)
  • Store generated code in Git (#3342)
  • Add a new docker image used to generate code (#3341)
  • Remove storybook from web code (#3339)
  • Implement list interface for filedb (#3329)
  • Change version in web copyable (#3337)
  • Run missing make gazelle (#3336)
  • Add etag to the object attribute struct (#3335)
  • Make link to docs icon clickable (#3333)
  • Run missing gazelle update (#3330)
  • Remove redis from api dependencies (#3326)
  • Remove environment model (#3324)
  • Implement create interface for filedb database (#3322)
  • Add description to the examples (#3321)
  • Add ContainLabels method for ApplicationInfo (#3319)
  • Add appSelector field for piped (#3318)
  • Add merge shards data for multiple shards stored object (#3316)
  • Define unregistered app cache (#3313)
  • change the port number of the local registry for macOS Montray (#3315)
  • Update feature status docs for Cloud Run (#3311)
  • Remove unused envCache (#3309)
  • Add proto message for better running version of applicaion (#3307)
  • Rename the title of Running Version column to Artifact Versions (#3308)
  • Fix func name (#3306)
  • Upgrade rules_go to v0.30.0 and go to 1.1.7.6 (#3305)
  • Remove gRPC related to env from auth (#3304)
  • Remove Environment related APIs (#3300)
  • Remove env related unused code from web (#3302)
  • Implement get interface for FileDB (#3286)
  • Fix typo (#3298)
  • Update actions-plan-preview to use pipectl v0.26.0 (#3297)

knanao
knanao reviewed Mar 17, 2022
View reviewed changes
Copy link
Member

@knanao knanao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
/lgtm

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Mar 17, 2022

COVERAGE

Code coverage for golang is 35.11%. This pull request decreases coverage by -0.41%.

File Function Base Head Diff
pkg/app/ops/insightcollector/collector.go NewCollector 0.00% 0.00% +0.00%
pkg/app/server/grpcapi/web_api.go WebAPI.GetInsightData 0.00% 0.00% +0.00%
pkg/insight/datapoint.go ChangeFailureRate.GetTimestamp 100.00% 0.00% -100.00%
pkg/app/piped/cloudprovider/kubernetes/kubectl.go Kubectl.Replace 0.00% 0.00% +0.00%
pkg/app/piped/executor/kubernetes/kubernetes.go deployExecutor.Execute 0.00% 0.00% +0.00%
pkg/insight/datapoint.go ToDataPoints 90.00% 50.00% -40.00%
pkg/insight/insightstore/chunkstore.go NewStore 100.00% 0.00% -100.00%
pkg/app/ops/insightcollector/collector.go Collector.Run 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/kubectl.go Kubectl.Create 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/kubectl.go Kubectl.Delete 0.00% 0.00% +0.00%
pkg/app/piped/executor/kubernetes/rollback.go rollbackExecutor.ensureRollback 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/kubectl.go Kubectl.Apply 0.00% 0.00% +0.00%
pkg/insight/datapoint.go DeployFrequency.Merge 66.67% 0.00% -66.67%
pkg/insight/datapoint.go UpdateDataPoint 80.00% 0.00% -80.00%
pkg/app/ops/insightcollector/collector.go Collector.collectDeploymentMetrics 0.00% -- +-0.00%
pkg/app/ops/insightcollector/collector.go Collector.processNewlyCreatedDeployments 0.00% -- +-0.00%
pkg/app/ops/insightcollector/collector.go Collector.processNewlyCompletedDeployments 0.00% -- +-0.00%
pkg/app/ops/insightcollector/deployments.go Collector.collectDeploymentChangeFailureRate 0.00% -- +-0.00%
pkg/app/ops/insightcollector/deployments.go Collector.collectDevelopmentFrequency 0.00% -- +-0.00%
pkg/app/ops/insightcollector/deployments.go Collector.findDeploymentsCreatedInRange 100.00% -- -100.00%
pkg/app/ops/insightcollector/deployments.go Collector.findDeploymentsCompletedInRange 100.00% -- -100.00%
pkg/app/ops/insightcollector/deployments.go Collector.updateApplicationChunks 0.00% -- +-0.00%
pkg/app/ops/insightcollector/deployments.go updateChunk 0.00% -- +-0.00%
pkg/app/ops/insightcollector/deployments.go updateDataPoints 76.92% -- -76.92%
pkg/app/ops/insightcollector/deployments.go extractDailyInsightDataPoints 94.44% -- -94.44%
pkg/app/ops/insightcollector/deployments.go extractDeployFrequency 100.00% -- -100.00%
pkg/app/ops/insightcollector/deployments.go extractChangeFailureRate 94.12% -- -94.12%
pkg/app/ops/insightcollector/deployments.go groupDeployments 100.00% -- -100.00%
pkg/insight/chunk.go DeployFrequencyChunk.GetFilePath 0.00% -- +-0.00%
pkg/insight/chunk.go DeployFrequencyChunk.SetFilePath 100.00% -- -100.00%
pkg/insight/chunk.go DeployFrequencyChunk.GetAccumulatedTo 0.00% -- +-0.00%
pkg/insight/chunk.go DeployFrequencyChunk.SetAccumulatedTo 100.00% -- -100.00%
pkg/insight/chunk.go DeployFrequencyChunk.GetDataPoints 83.33% -- -83.33%
pkg/insight/chunk.go DeployFrequencyChunk.SetDataPoints 90.00% -- -90.00%
pkg/insight/chunk.go ChangeFailureRateChunk.GetFilePath 0.00% -- +-0.00%
pkg/insight/chunk.go ChangeFailureRateChunk.SetFilePath 100.00% -- -100.00%
pkg/insight/chunk.go ChangeFailureRateChunk.GetAccumulatedTo 0.00% -- +-0.00%
pkg/insight/chunk.go ChangeFailureRateChunk.SetAccumulatedTo 100.00% -- -100.00%
pkg/insight/chunk.go ChangeFailureRateChunk.GetDataPoints 33.33% -- -33.33%
pkg/insight/chunk.go ChangeFailureRateChunk.SetDataPoints 60.00% -- -60.00%
pkg/insight/chunk.go NewChunk 0.00% -- +-0.00%
pkg/insight/chunk.go ToChunk 75.00% -- -75.00%
pkg/insight/chunk.go Chunks.ExtractDataPoints 68.75% -- -68.75%
pkg/insight/filepath.go MakeYearsFilePath 100.00% -- -100.00%
pkg/insight/filepath.go MakeChunkFilePath 100.00% -- -100.00%
pkg/insight/filepath.go DetermineFilePaths 90.00% -- -90.00%
pkg/insight/filepath.go determineChunkKeys 92.86% -- -92.86%
pkg/insight/insightstore/chunkstore.go store.LoadChunks 88.89% -- -88.89%
pkg/insight/insightstore/chunkstore.go store.PutChunk 0.00% -- +-0.00%
pkg/insight/insightstore/chunkstore.go LoadChunksFromCache 0.00% -- +-0.00%
pkg/insight/insightstore/chunkstore.go PutChunksToCache 0.00% -- +-0.00%
pkg/insight/insightstore/chunkstore.go store.getChunk 81.25% -- -81.25%
pkg/insight/utils.go NormalizeTime 100.00% -- -100.00%

@khanhtc1202
Copy link
Member

khanhtc1202 commented Mar 17, 2022

Nice work
/approve

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Mar 17, 2022

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit bbcba28 into master Mar 17, 2022
@pipecd-bot pipecd-bot deleted the kubeconfig branch March 17, 2022 07:22
This was referenced Mar 18, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202

1 more reviewer

@knanao knanao knanao left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved area/piped lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

kubectl does not use spec.cloudProviders[].config.kubeConfigPath

5 participants

@nghialv @pipecd-bot @khanhtc1202 @knanao