Define RBAC resource model #3392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The following files are not gofmt-ed. By commenting pkg/model/project.pb.go--- pkg/model/project.pb.go.orig
+++ pkg/model/project.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
|
nghialv
reviewed
Mar 15, 2022
nghialv
reviewed
Mar 15, 2022
Collaborator
|
The following files are not gofmt-ed. By commenting pkg/model/project.pb.go--- pkg/model/project.pb.go.orig
+++ pkg/model/project.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
|
Collaborator
Collaborator
|
Code coverage for javascript is
|
Member
Author
|
I'll fix some points. so let me hold this PR temporally. |
Collaborator
|
The following files are not gofmt-ed. By commenting pkg/model/project.pb.go--- pkg/model/project.pb.go.orig
+++ pkg/model/project.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
|
Collaborator
|
Code coverage for golang is
|
nghialv
reviewed
Mar 16, 2022
Collaborator
|
Code coverage for javascript is
|
nghialv
reviewed
Mar 16, 2022
nghialv
reviewed
Mar 16, 2022
nghialv
reviewed
Mar 16, 2022
nghialv
reviewed
Mar 16, 2022
nghialv
reviewed
Mar 16, 2022
Collaborator
|
The following files are not gofmt-ed. By commenting pkg/model/project.pb.go--- pkg/model/project.pb.go.orig
+++ pkg/model/project.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
|
Member
Author
|
/hold cancel |
Collaborator
|
Code coverage for golang is |
Collaborator
|
The following files are not gofmt-ed. By commenting pkg/model/project.pb.go--- pkg/model/project.pb.go.orig
+++ pkg/model/project.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
|
Collaborator
|
Code coverage for golang is |
Collaborator
|
Code coverage for javascript is |
Member
|
Nice. Thank you. /lgtm |
Member
|
Here you go 👍 |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
Collaborator
|
failed to handle template rule manifests Details |
This was referenced Mar 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Define RBAC resource model to make it easier to manage a large number of applications
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: