Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Mar 7, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. This is just a temporary solution. We will move to have .codegen.yaml config file instead of hard coding like this.

# TODO: This is just a temporary solution. We will move to have .codegen.yaml config file instead of hard coding like this.
mockPackageNames=(
"redistest"
"datastoretest"

This was created by todo plugin since "TODO:" was found in a30946d when #3356 was merged. cc: @nghialv.

@pipecd-bot
Copy link
Collaborator

DOCKER

A Kapetanios build has just been triggered to run docker operations for the following 1 directory.
Their results will be reported back after the build is completed.

  1. dockers/codegen

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

pkg/filestore/filestoretest/filestore.mock.go
--- pkg/filestore/filestoretest/filestore.mock.go.orig
+++ pkg/filestore/filestoretest/filestore.mock.go
@@ -10,6 +10,7 @@
 	reflect "reflect"
 
 	gomock "github.com/golang/mock/gomock"
+
 	filestore "github.com/pipe-cd/pipecd/pkg/filestore"
 )
 
pkg/git/gittest/git.mock.go
--- pkg/git/gittest/git.mock.go.orig
+++ pkg/git/gittest/git.mock.go
@@ -9,6 +9,7 @@
 	reflect "reflect"
 
 	gomock "github.com/golang/mock/gomock"
+
 	git "github.com/pipe-cd/pipecd/pkg/git"
 )
 
pkg/insight/insightstore/insightstoretest/insightstore.mock.go
--- pkg/insight/insightstore/insightstoretest/insightstore.mock.go.orig
+++ pkg/insight/insightstore/insightstoretest/insightstore.mock.go
@@ -10,6 +10,7 @@
 	time "time"
 
 	gomock "github.com/golang/mock/gomock"
+
 	insight "github.com/pipe-cd/pipecd/pkg/insight"
 	model "github.com/pipe-cd/pipecd/pkg/model"
 )
pkg/jwt/jwttest/jwt.mock.go
--- pkg/jwt/jwttest/jwt.mock.go.orig
+++ pkg/jwt/jwttest/jwt.mock.go
@@ -8,6 +8,7 @@
 	reflect "reflect"
 
 	gomock "github.com/golang/mock/gomock"
+
 	jwt "github.com/pipe-cd/pipecd/pkg/jwt"
 )
 
pkg/app/piped/cloudprovider/kubernetes/providertest/provider.mock.go
--- pkg/app/piped/cloudprovider/kubernetes/providertest/provider.mock.go.orig
+++ pkg/app/piped/cloudprovider/kubernetes/providertest/provider.mock.go
@@ -9,6 +9,7 @@
 	reflect "reflect"
 
 	gomock "github.com/golang/mock/gomock"
+
 	kubernetes "github.com/pipe-cd/pipecd/pkg/app/piped/cloudprovider/kubernetes"
 )
 
pkg/datastore/datastoretest/datastore.mock.go
--- pkg/datastore/datastoretest/datastore.mock.go.orig
+++ pkg/datastore/datastoretest/datastore.mock.go
@@ -10,6 +10,7 @@
 	time "time"
 
 	gomock "github.com/golang/mock/gomock"
+
 	datastore "github.com/pipe-cd/pipecd/pkg/datastore"
 	model "github.com/pipe-cd/pipecd/pkg/model"
 )

@pipecd-bot
Copy link
Collaborator

DOCKER

The Kapetanios build to run docker operations for the following 1 directory has been completed.

1. dockers/codegen - success

An image named codegen:0.4.0-a30946d was procuded for reviewing and testing.
By merging this PR, an image named codegen:0.4.0 will be pushed to the container registry.

There is no test to run inside this directory.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.45%. This pull request does not change code coverage.

@knanao
Copy link
Member

knanao commented Mar 7, 2022

Nice catch!
Let's add validation job for CI later in order to check whether we generated mock or something.
/lgtm

@pipecd-bot pipecd-bot added the lgtm label Mar 7, 2022
@nghialv
Copy link
Member Author

nghialv commented Mar 7, 2022

@knanao
Copy link
Member

knanao commented Mar 7, 2022

@nghialv
Oh, how fast! Thank you.

@nghialv
Copy link
Member Author

nghialv commented Mar 7, 2022

Thank you. Please let me merge this.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants