-
Notifications
You must be signed in to change notification settings - Fork 204
Use codegen to generate Go mock files #3356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use Details1. This is just a temporary solution. We will move to have .codegen.yaml config file instead of hard coding like this.pipecd/dockers/codegen/codegen.sh Lines 86 to 89 in a30946d
This was created by todo plugin since "TODO:" was found in a30946d when #3356 was merged. cc: @nghialv. |
|
A Kapetanios build has just been triggered to run docker operations for the following
|
|
The following files are not gofmt-ed. By commenting pkg/filestore/filestoretest/filestore.mock.go--- pkg/filestore/filestoretest/filestore.mock.go.orig
+++ pkg/filestore/filestoretest/filestore.mock.go
@@ -10,6 +10,7 @@
reflect "reflect"
gomock "github.com/golang/mock/gomock"
+
filestore "github.com/pipe-cd/pipecd/pkg/filestore"
)
pkg/git/gittest/git.mock.go--- pkg/git/gittest/git.mock.go.orig
+++ pkg/git/gittest/git.mock.go
@@ -9,6 +9,7 @@
reflect "reflect"
gomock "github.com/golang/mock/gomock"
+
git "github.com/pipe-cd/pipecd/pkg/git"
)
pkg/insight/insightstore/insightstoretest/insightstore.mock.go--- pkg/insight/insightstore/insightstoretest/insightstore.mock.go.orig
+++ pkg/insight/insightstore/insightstoretest/insightstore.mock.go
@@ -10,6 +10,7 @@
time "time"
gomock "github.com/golang/mock/gomock"
+
insight "github.com/pipe-cd/pipecd/pkg/insight"
model "github.com/pipe-cd/pipecd/pkg/model"
)
pkg/jwt/jwttest/jwt.mock.go--- pkg/jwt/jwttest/jwt.mock.go.orig
+++ pkg/jwt/jwttest/jwt.mock.go
@@ -8,6 +8,7 @@
reflect "reflect"
gomock "github.com/golang/mock/gomock"
+
jwt "github.com/pipe-cd/pipecd/pkg/jwt"
)
pkg/app/piped/cloudprovider/kubernetes/providertest/provider.mock.go--- pkg/app/piped/cloudprovider/kubernetes/providertest/provider.mock.go.orig
+++ pkg/app/piped/cloudprovider/kubernetes/providertest/provider.mock.go
@@ -9,6 +9,7 @@
reflect "reflect"
gomock "github.com/golang/mock/gomock"
+
kubernetes "github.com/pipe-cd/pipecd/pkg/app/piped/cloudprovider/kubernetes"
)
pkg/datastore/datastoretest/datastore.mock.go--- pkg/datastore/datastoretest/datastore.mock.go.orig
+++ pkg/datastore/datastoretest/datastore.mock.go
@@ -10,6 +10,7 @@
time "time"
gomock "github.com/golang/mock/gomock"
+
datastore "github.com/pipe-cd/pipecd/pkg/datastore"
model "github.com/pipe-cd/pipecd/pkg/model"
)
|
|
The Kapetanios build to run docker operations for the following 1. dockers/codegen - successAn image named codegen:0.4.0-a30946d was procuded for reviewing and testing. There is no test to run inside this directory. |
|
Nice catch! |
|
@knanao Thanks for your comment. It validated this PR as well. |
|
@nghialv |
|
Thank you. Please let me merge this. |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: