Skip to content

Conversation

@Hosshii
Copy link
Member

@Hosshii Hosshii commented Mar 11, 2022

What this PR does / why we need it:
Order option must include id field.

return "", fmt.Errorf("id field is required as ordering field")

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@khanhtc1202
Copy link
Member

Nice catch 😀
/approve

Field: "CreatedAt",
Direction: datastore.Desc,
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hosshii you may need to update firestore index as well to enable this query to work. Firestore indexes stored under pkg/app/ops/firestoreindexensurer/indexes.json

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thank you!

@khanhtc1202
Copy link
Member

/approve cancel

@pipecd-bot pipecd-bot added size/M and removed size/XS labels Mar 11, 2022
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.48%. This pull request increases coverage by 0.08%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/ecs/task.go FindArtifactVersions -- 100.00% +100.00%
pkg/app/piped/planner/ecs/ecs.go determineVersions -- 0.00% +0.00%
pkg/app/piped/cloudprovider/ecs/task.go parseContainerImage 0.00% 100.00% +100.00%
pkg/app/piped/planner/ecs/ecs.go Planner.Plan 0.00% 0.00% +0.00%

@pipecd-bot pipecd-bot added size/L and removed size/M labels Mar 11, 2022
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.48%. This pull request increases coverage by 0.08%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/ecs/task.go FindArtifactVersions -- 100.00% +100.00%
pkg/app/piped/planner/ecs/ecs.go determineVersions -- 0.00% +0.00%
pkg/app/piped/cloudprovider/ecs/task.go parseContainerImage 0.00% 100.00% +100.00%
pkg/app/piped/planner/ecs/ecs.go Planner.Plan 0.00% 0.00% +0.00%

@Hosshii
Copy link
Member Author

Hosshii commented Mar 11, 2022

I fixed. PTAL

Copy link
Member

@knanao knanao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!
/lgtm

@khanhtc1202
Copy link
Member

Nice catch ⚾
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

This was referenced Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants