-
Notifications
You must be signed in to change notification settings - Fork 204
Add id to condition #3387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add id to condition #3387
Conversation
|
Nice catch 😀 |
| Field: "CreatedAt", | ||
| Direction: datastore.Desc, | ||
| }, | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hosshii you may need to update firestore index as well to enable this query to work. Firestore indexes stored under pkg/app/ops/firestoreindexensurer/indexes.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thank you!
|
/approve cancel |
|
Code coverage for golang is
|
|
Code coverage for golang is
|
|
I fixed. PTAL |
knanao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
/lgtm
|
Nice catch ⚾ |
What this PR does / why we need it:
Order option must include id field.
pipecd/pkg/datastore/mysql/query.go
Line 165 in 9a1ba99
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: