Enable to filter suggested applications when you add an application from controlplane #3320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knanao
changed the title
Collaborator
|
Code coverage for golang is
|
nghialv
reviewed
Feb 28, 2022
docs/content/en/docs-dev/operator-manual/piped/configuration-reference.md
Outdated
Show resolved
Hide resolved
Member
|
Nice. Just a nit about the release note:
|
…eference.md Co-authored-by: Le Van Nghia <[email protected]>
Collaborator
|
Code coverage for golang is
|
Member
|
Thank you. |
khanhtc1202
reviewed
Feb 28, 2022
| | eventWatcher | [EventWatcher](/docs/operator-manual/piped/configuration-reference/#eventwatcher) | Optional Event watcher settings. | No | | ||
| | secretManagement | [SecretManagement](/docs/operator-manual/piped/configuration-reference/#secretmanagement) | The using secret management method. | No | | ||
| | notifications | [Notifications](/docs/operator-manual/piped/configuration-reference/#notifications) | Sending notifications to Slack, Webhook... | No | | ||
| | appSelector | map[string]string | List of labels to filter all applications this piped will handle. Currently, it is only be used to filter the applications suggested for adding from the control plane. | No | |
Member
There was a problem hiding this comment.
not really related to this pull but I just realized that this is List of ... so should we change the name as appSelectors?
Member
Author
There was a problem hiding this comment.
This is based on k8s selector.
But it seems good to combine appSelectors with labels. wdyt?
Member
There was a problem hiding this comment.
Then it will be appLabelsSelector right? 😄
Member
There was a problem hiding this comment.
on the second thought, I guess labels is unnecessary, so I think we should keep it as is. Sorry for the interruption 🙏
Member
Author
There was a problem hiding this comment.
Umm.., It took me a while to think appSelector is okay.
Do you feel a bit strange?
Member
There was a problem hiding this comment.
Yep, so lets keep it as is, thank you 🙌
Member
|
Nice work, thanks |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
This was referenced Mar 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If you want piped to monitor only certain applications,
appSelectoris useful.If not specified, all application will be suggested when you add an application.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: