-
Notifications
You must be signed in to change notification settings - Fork 204
Fix bug that Launcher could not load the new format of Piped config #3361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pipecd-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| return nil | ||
| } | ||
|
|
||
| type LauncherSpec struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type name will be used as launcher.LauncherSpec by other packages, and that stutters; consider calling this Spec
|
Code coverage for golang is
|
|
Nice catch! |
| return nil | ||
| } | ||
|
|
||
| type LauncherSpec struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits, is it enough to make this struct just a private struct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it would be okay to define it in /config. but it's up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Fixed them. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it would be okay to define it in /config. but it's up to you.
I feel you. That is nice too. Let me apply your suggestion. 👍
|
Code coverage for golang is
|
|
Nice 👍 |
|
btw, I think we may need to add something like: "Fix bug that Launcher could not load the new format of Piped config" as this PR introduces a user-facing change block. |
Oops. I was thinking that I had already configured it. |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: