Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Mar 8, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Copy link
Collaborator

@pipecd-bot pipecd-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_LINTER

Some issues were detected while linting go source files in your changes.

return nil
}

type LauncherSpec struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type name will be used as launcher.LauncherSpec by other packages, and that stutters; consider calling this Spec

https://golang.org/wiki/CodeReviewComments#package-names

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.41%. This pull request decreases coverage by -0.05%.

File Function Base Head Diff
pkg/app/launcher/cmd/launcher/launcher.go Config.Validate -- 0.00% +0.00%
pkg/app/launcher/cmd/launcher/launcher.go LauncherSpec.LoadPipedKey -- 0.00% +0.00%
pkg/app/launcher/cmd/launcher/launcher.go parseConfig 0.00% 0.00% +0.00%

@knanao
Copy link
Member

knanao commented Mar 8, 2022

Nice catch!
/lgtm

@pipecd-bot pipecd-bot added the lgtm label Mar 8, 2022
return nil
}

type LauncherSpec struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits, is it enough to make this struct just a private struct?

Copy link
Member

@knanao knanao Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would be okay to define it in /config. but it's up to you.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Fixed them. 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would be okay to define it in /config. but it's up to you.

I feel you. That is nice too. Let me apply your suggestion. 👍

@pipecd-bot pipecd-bot removed the lgtm label Mar 8, 2022
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.41%. This pull request decreases coverage by -0.05%.

File Function Base Head Diff
pkg/app/launcher/cmd/launcher/launcher.go launcherConfig.Validate -- 0.00% +0.00%
pkg/app/launcher/cmd/launcher/launcher.go launcherSpec.LoadPipedKey -- 0.00% +0.00%
pkg/app/launcher/cmd/launcher/launcher.go parseConfig 0.00% 0.00% +0.00%

@khanhtc1202
Copy link
Member

Nice 👍
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit ef020b1 into master Mar 8, 2022
@pipecd-bot pipecd-bot deleted the launcher-config branch March 8, 2022 03:12
@khanhtc1202
Copy link
Member

btw, I think we may need to add something like: "Fix bug that Launcher could not load the new format of Piped config" as this PR introduces a user-facing change block.

@nghialv
Copy link
Member Author

nghialv commented Mar 8, 2022

btw, I think we may need to add something like: "Fix bug that Launcher could not load the new format of Piped config" as this PR introduces a user-facing change block.

Oops. I was thinking that I had already configured it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants