Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Mar 4, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

DOCKER

A Kapetanios build has just been triggered to run docker operations for the following 1 directory.
Their results will be reported back after the build is completed.

  1. dockers/codegen

@khanhtc1202 khanhtc1202 changed the title Add a new docker iamge used to generate code Add a new docker image used to generate code Mar 4, 2022
@pipecd-bot
Copy link
Collaborator

DOCKER

The Kapetanios build to run docker operations for the following 1 directory has been completed.

1. dockers/codegen - success

An image named codegen:0.1.0-7a34523 was procuded for reviewing and testing.
By merging this PR, an image named codegen:0.1.0 will be pushed to the container registry.

There is no test to run inside this directory.

Makefile Outdated

.PHONY: codegen
codegen:
docker run -v $PWD:/repo -it gcr.io/pipecd/codegen:0.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits, without container name, I think we should add --rm to remove the container after it exits

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 💯

@pipecd-bot
Copy link
Collaborator

DOCKER

A Kapetanios build has just been triggered to run docker operations for the following 1 directory.
Their results will be reported back after the build is completed.

  1. dockers/codegen

@pipecd-bot
Copy link
Collaborator

DOCKER

The Kapetanios build to run docker operations for the following 1 directory has been completed.

1. dockers/codegen - success

An image named codegen:0.1.0-8dc84ff was procuded for reviewing and testing.
By merging this PR, an image named codegen:0.1.0 will be pushed to the container registry.

There is no test to run inside this directory.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.39%. This pull request does not change code coverage.

@khanhtc1202
Copy link
Member

Nice improvement 🙌
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants