-
Notifications
You must be signed in to change notification settings - Fork 204
Add a new docker image used to generate code #3341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A Kapetanios build has just been triggered to run docker operations for the following
|
|
The Kapetanios build to run docker operations for the following 1. dockers/codegen - successAn image named codegen:0.1.0-7a34523 was procuded for reviewing and testing. There is no test to run inside this directory. |
Makefile
Outdated
|
|
||
| .PHONY: codegen | ||
| codegen: | ||
| docker run -v $PWD:/repo -it gcr.io/pipecd/codegen:0.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits, without container name, I think we should add --rm to remove the container after it exits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! 💯
|
A Kapetanios build has just been triggered to run docker operations for the following
|
|
The Kapetanios build to run docker operations for the following 1. dockers/codegen - successAn image named codegen:0.1.0-8dc84ff was procuded for reviewing and testing. There is no test to run inside this directory. |
|
Nice improvement 🙌 |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: