Show artifact versions

[ffjlabo]

What this PR does / why we need it:

This PR changes to show artifact versions with links.

Which issue(s) this PR fixes:

A part of #3303

Does this PR introduce a user-facing change?:

Be able to show artifact versions with links

[pipecd-bot]

Code coverage for golang is 32.40%. This pull request does not change code coverage.

[pipecd-bot]

Code coverage for javascript is 78.03%. This pull request decreases coverage by -0.04%.

File	Base	Head	Diff
src/components/application-detail-page/application-detail/index.tsx	94.55%	92.86%	-1.69%
src/components/applications-page/application-list/application-list-item/index.tsx	89.36%	87.76%	-1.61%

[khanhtc1202]

should only add this // in case the url does not contain schema.
Can use v.url.includes(://) as the condition.

[nghialv]

Love this!

What do you guys thing about changing the layout of the version?
For example, v0.6.0 (helloworld) -> helloworld:v0.6.0.

[nghialv]

Btw, should we trim the version in case it is too long?

Like commit hash, we should show only the first 7 characters.

helloworld:36515f2... instead of helloworld:sha36515f2d60ad86cc1f7b7e8d97e935741e5cf9f1

[ffjlabo]

Love this!

What do you guys thing about changing the layout of the version? For example, v0.6.0 (helloworld) -> helloworld:v0.6.0.

I see, may be helloworld:v0.6.0 style is natural for users because they often show that style in artifact files (e.g. k8s manifest).

Btw, should we trim the version in case it is too long?

Like commit hash, we should show only the first 7 characters.

helloworld:36515f2... instead of helloworld:sha36515f2d60ad86cc1f7b7e8d97e935741e5cf9f1

I agree with it!

[pipecd-bot]

Code coverage for golang is 32.40%. This pull request does not change code coverage.

[pipecd-bot]

Code coverage for javascript is 78.00%. This pull request decreases coverage by -0.06%.

File	Base	Head	Diff
src/components/application-detail-page/application-detail/index.tsx	94.55%	92.86%	-1.69%
src/components/applications-page/application-list/application-list-item/index.tsx	89.36%	87.76%	-1.61%
src/modules/commands/index.ts	90.62%	93.75%	+3.12%
src/modules/project/index.ts	60.38%	56.60%	-3.77%

[ffjlabo]

How about the above?

[nghialv]

How about the above?

@khanhtc1202 @knanao what do you think?

[khanhtc1202]

yeh, one vote from me. Please go ahead and address it 🙏

[ffjlabo]

These are after fixed.

[pipecd-bot]

Code coverage for golang is 32.40%. This pull request does not change code coverage.

[khanhtc1202]

nits, I think we should only trim the long text as it's a table cell content. On the detail page, we should just show it clearly, wdyt?

[nghialv]

nits, I think we should only trim the long text as it's a table cell content. On the detail page, we should just show it clearly, wdyt?

I feel the same too. And maybe we also should split them into multiple lines on the application detail page.

[pipecd-bot]

Code coverage for javascript is 77.98%. This pull request decreases coverage by -0.09%.

File	Base	Head	Diff
src/components/applications-page/application-list/application-list-item/index.tsx	89.36%	87.76%	-1.61%
src/modules/project/index.ts	60.38%	56.60%	-3.77%
src/components/application-detail-page/application-detail/index.tsx	94.55%	92.86%	-1.69%

[ffjlabo]

I see! Then I'll fix to truncate it in case the long text over the size of the table cell.

[ffjlabo]

On the detail page, I fixed it to show full version info and split them into multiple lines.

[pipecd-bot]

Code coverage for golang is 32.40%. This pull request does not change code coverage.

[nghialv]

Looks beautiful! ❤️
/lgmt

[nghialv]

/lgtm

[ffjlabo]

sorry I found some mistakes, so I'll fix

[pipecd-bot]

Code coverage for javascript is 78.03%. This pull request decreases coverage by -0.04%.

File	Base	Head	Diff
src/components/application-detail-page/application-detail/index.tsx	94.55%	92.86%	-1.69%
src/components/applications-page/application-list/application-list-item/index.tsx	89.36%	87.76%	-1.61%

[pipecd-bot]

Code coverage for golang is 32.40%. This pull request does not change code coverage.

[ffjlabo]

I fixed, PTAL. 🙇

[pipecd-bot]

Code coverage for javascript is 78.06%. This pull request decreases coverage by -0.01%.

File	Base	Head	Diff
src/components/application-detail-page/application-detail/index.tsx	94.55%	92.86%	-1.69%
src/components/applications-page/application-list/application-list-item/index.tsx	89.36%	87.76%	-1.61%
src/modules/commands/index.ts	90.62%	93.75%	+3.12%

[nghialv]

👍
/lgtm

[khanhtc1202]

it's beautiful, thank you 😀
/approve

[pipecd-bot]

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.