Skip to content

Conversation

@khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Feb 21, 2022

What this PR does / why we need it:

By this PR, I did

Which issue(s) this PR fixes:

Fixes #3222

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.55%. This pull request increases coverage by 0.21%.

File Function Base Head Diff
pkg/app/piped/planner/kubernetes/kubernetes.go findUpdatedWorkloads 93.33% 100.00% +6.67%
pkg/app/piped/planner/kubernetes/kubernetes.go checkImageChange 30.77% 100.00% +69.23%
pkg/app/server/grpcapi/api.go API.ListApplications 0.00% 0.00% +0.00%
pkg/app/server/grpcapi/grpcapi.go getEnvironment 0.00% -- +-0.00%
pkg/app/server/grpcapi/piped_api.go PipedAPI.GetEnvironment 0.00% -- +-0.00%
pkg/app/server/grpcapi/piped_api.go PipedAPI.validateEnvBelongsToProject 91.67% -- -91.67%
pkg/app/server/grpcapi/web_api.go WebAPI.UpdateEnvironmentDesc 0.00% -- +-0.00%
pkg/app/server/grpcapi/web_api.go WebAPI.ListEnvironments 0.00% -- +-0.00%
pkg/app/server/grpcapi/web_api.go WebAPI.EnableEnvironment 0.00% -- +-0.00%
pkg/app/server/grpcapi/web_api.go WebAPI.DisableEnvironment 0.00% -- +-0.00%
pkg/app/server/grpcapi/web_api.go WebAPI.DeleteEnvironment 0.00% -- +-0.00%
pkg/app/server/grpcapi/web_api.go WebAPI.updateEnvironmentEnable 0.00% -- +-0.00%
pkg/app/server/grpcapi/web_api.go WebAPI.validateEnvBelongsToProject 0.00% -- +-0.00%
pkg/datastore/environmentstore.go environmentCollection.Kind 0.00% -- +-0.00%
pkg/datastore/environmentstore.go environmentCollection.Factory 0.00% -- +-0.00%
pkg/datastore/environmentstore.go NewEnvironmentStore 100.00% -- -100.00%
pkg/datastore/environmentstore.go environmentStore.Get 100.00% -- -100.00%
pkg/datastore/environmentstore.go environmentStore.List 84.62% -- -84.62%
pkg/datastore/environmentstore.go environmentStore.Delete 0.00% -- +-0.00%
pkg/datastore/environmentstore.go environmentStore.EnableEnvironment 0.00% -- +-0.00%
pkg/datastore/environmentstore.go environmentStore.DisableEnvironment 0.00% -- +-0.00%
pkg/model/environment.go MakeEnvironmentURL 100.00% -- -100.00%

@nghialv
Copy link
Member

nghialv commented Feb 22, 2022

Feel really good.
/lgtm

@knanao
Copy link
Member

knanao commented Feb 22, 2022

Thank you!
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by knanao.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Environment related APIs

5 participants