Display version information to web #3328

Hosshii · 2022-03-01T10:06:12Z

What this PR does / why we need it:
Display version information to web.

Which issue(s) this PR fixes:

Fixes #1958

Does this PR introduce a user-facing change?:

Show running version and documentation link on the web console

khanhtc1202 · 2022-03-01T10:09:25Z

pkg/app/web/src/components/header/index.tsx

+          </Link>
+        </MenuItem>
+        <MenuItem disabled={true} dense={true}>
+          {process.env.STABLE_VERSION?.substring(0, 10)}


Suggested change

{process.env.STABLE_VERSION?.substring(0, 10)}

Version: {process.env.STABLE_VERSION?.substring(0, 10)}

nits

btw, not sure why do we need to cut the string, why not just show the full version string? Since the last part is the commit hash and can be used to refer to source code on pipecd repo, which could be useful in some cases 👀

I think this one is easier to understand, but the display looks like this. Which one do you think is better?

I get your point 👍 Then, how about remove the Version: part and show the full version string?

Sorry, my comment was not updated and I missed it.
This is what it looks like when I put them all up. Personally, I find it too long.

That is exactly what I was thinking about.

About the version string, I think showing the full one is fine. Because on the production it is not that long.

Thank you!
I changed Docs to Documentation and add a icon.

Looks so beautiful!

Just a nit:

How do you think about moving the menu popup to be lower to avoid overlapping the tab bar?
We can resolve it in another PR.

Than sounds good to me.

pkg/app/web/package.json

pipecd-bot · 2022-03-01T10:14:00Z

Code coverage for golang is 32.51%. This pull request does not change code coverage.

pipecd-bot · 2022-03-01T10:19:30Z

Code coverage for javascript is 78.01%. This pull request decreases coverage by -0.05%.

File	Base	Head	Diff
src/modules/project/index.ts	`60.38%`	`56.60%`	`-3.77%`

pipecd-bot · 2022-03-01T10:30:15Z

Code coverage for golang is 32.51%. This pull request does not change code coverage.

pipecd-bot · 2022-03-01T10:36:15Z

Code coverage for javascript is 78.09%. This pull request increases coverage by 0.03%.

File	Base	Head	Diff
src/modules/commands/index.ts	`90.62%`	`93.75%`	`+3.12%`

nghialv · 2022-03-02T01:30:27Z

pkg/app/web/src/components/header/index.tsx

+            target="_blank"
+            rel="noreferrer"
+          >
+            Docs


Suggested change

Docs

Documentation

nghialv · 2022-03-02T02:48:21Z

Great job! Thank you.
/lgtm

Nit about the release note

Show running version and documentation link on the web console

khanhtc1202 · 2022-03-02T02:57:18Z

It's beautiful 😁
/approve

pipecd-bot · 2022-03-02T02:57:21Z

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Hosshii · 2022-03-02T03:01:54Z

@nghialv
Sorry, I didn't push the code because I thought there might be more changes. I have pushed 986df95 that apply this comment #3328 (comment).

nghialv · 2022-03-02T03:03:14Z

@nghialv Sorry, I didn't push the code because I thought there might be more changes. I have pushed 986df95 .

Got it. 👍

**What this PR does / why we need it**: Move the menu for visibility. And fix version placeholder. before <img width="377" alt="image" src="https://user-images.githubusercontent.com/49914427/156295069-38ecaa97-facb-4845-8e1b-87d0b745d359.png"> after <img width="382" alt="image" src="https://user-images.githubusercontent.com/49914427/156294841-49850e17-463c-4b5a-9732-d57ebe8550ff.png"> **Which issue(s) this PR fixes**: #3328 (comment) **Does this PR introduce a user-facing change?**:  ```release-note Move menu to be lower to avoid overlapping the tab bar. ``` This PR was merged by Kapetanios.

**What this PR does / why we need it**: This PR changes [versions](#3328) to selectable and copyable for convenience. <img width="376" alt="image" src="https://user-images.githubusercontent.com/49914427/156507069-2061276a-4dd6-428b-96d0-f25fc495a8dc.png"> **Which issue(s) this PR fixes**: Fixes # **Does this PR introduce a user-facing change?**:  ```release-note NONE ``` This PR was merged by Kapetanios.

Hosshii added 3 commits March 1, 2022 18:50

dev setting

27aa888

bazel version

8d89b55

display version

c38652c

pipecd-bot added size/M area/web labels Mar 1, 2022

pipecd-bot requested review from khanhtc1202, knanao and nghialv March 1, 2022 10:06

khanhtc1202 reviewed Mar 1, 2022

View reviewed changes

pkg/app/web/package.json Outdated Show resolved Hide resolved

add newline

fde3562

nghialv reviewed Mar 2, 2022

View reviewed changes

fix style

986df95

pipecd-bot added lgtm and removed lgtm labels Mar 2, 2022

pipecd-bot added the approved label Mar 2, 2022

pipecd-bot merged commit 2b4b9d4 into master Mar 2, 2022

pipecd-bot deleted the web_version branch March 2, 2022 03:09

Hosshii mentioned this pull request Mar 2, 2022

Move menu to be lower to avoid overlapping the tab bar. #3332

Merged

Hosshii mentioned this pull request Mar 3, 2022

Change version in web copyable #3337

Merged

pipecd-bot mentioned this pull request Mar 8, 2022

Move launcher config to config package #3362

Merged

This was referenced Mar 17, 2022

Fix bug that the specified kubeConfigPath in Piped config was not used while handling manifests #3410

Merged

Use the latest codegen #3414

Merged

Delete unneeded CODEOWNERS file #3416

Merged

	{process.env.STABLE_VERSION?.substring(0, 10)}
	Version: {process.env.STABLE_VERSION?.substring(0, 10)}

Display version information to web #3328

Display version information to web #3328

Uh oh!

Conversation

Hosshii commented Mar 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Hosshii Mar 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pipecd-bot commented Mar 1, 2022

Uh oh!

pipecd-bot commented Mar 1, 2022

Uh oh!

pipecd-bot commented Mar 1, 2022

Uh oh!

pipecd-bot commented Mar 1, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nghialv commented Mar 2, 2022

Uh oh!

khanhtc1202 commented Mar 2, 2022

Uh oh!

pipecd-bot commented Mar 2, 2022

Uh oh!

Hosshii commented Mar 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nghialv commented Mar 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Hosshii commented Mar 1, 2022 •

edited

Loading

Hosshii Mar 1, 2022 •

edited

Loading

Hosshii commented Mar 2, 2022 •

edited

Loading