Skip to content

Switch to use code generated by codegen's protoc #3355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pipecd-bot merged 4 commits into from
Mar 7, 2022
Merged

Switch to use code generated by codegen's protoc #3355

pipecd-bot merged 4 commits into from
Mar 7, 2022

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Mar 4, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot pipecd-bot requested a review from khanhtc1202 March 4, 2022 13:13
@pipecd-bot pipecd-bot requested a review from knanao March 4, 2022 13:13
khanhtc1202
khanhtc1202 reviewed Mar 4, 2022
View reviewed changes
WORKSPACE
Comment on lines -53 to -52
### Protoc-gen-validate
git_repository(
name = "com_github_envoyproxy_protoc_gen_validate",
commit = "9eff07ddfcb4001aa1aab280648153f46e1a8ddc",
remote = "https://github.com/envoyproxy/protoc-gen-validate.git",
shallow_since = "1560436592 +0000",
)
Copy link
Member

@khanhtc1202 khanhtc1202 Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally 👋

Copy link
Member Author

@nghialv nghialv Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@khanhtc1202
Copy link
Member

khanhtc1202 commented Mar 4, 2022

Here you go 👍
/approve

@khanhtc1202
Copy link
Member

khanhtc1202 commented Mar 7, 2022

/rebase

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Mar 7, 2022

REBASE

@khanhtc1202: Rebased this pull request in response to this comment.

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Mar 7, 2022

DOCKER

A Kapetanios build has just been triggered to run docker operations for the following 1 directory.
Their results will be reported back after the build is completed.

  1. dockers/codegen

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Mar 7, 2022

DOCKER

The Kapetanios build to run docker operations for the following 1 directory has been completed.

1. dockers/codegen - success

An image named codegen:0.5.0-5dd0dcb was procuded for reviewing and testing.
By merging this PR, an image named codegen:0.5.0 will be pushed to the container registry.

There is no test to run inside this directory.

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Mar 7, 2022

COVERAGE

Code coverage for golang is 32.45%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Mar 7, 2022

COVERAGE

Code coverage for javascript is 78.07%. This pull request decreases coverage by -0.03%.

File Base Head Diff
src/modules/commands/index.ts 93.75% 90.62% -3.12%

@nghialv
Copy link
Member Author

nghialv commented Mar 7, 2022

Fixed this PR. Please take a look at this when you have time.
(The CodeGen action returned an error but it is ok to ignore it at this time.)

@khanhtc1202
Copy link
Member

khanhtc1202 commented Mar 7, 2022

Nice work
/lgtm

@pipecd-bot pipecd-bot added the lgtm label Mar 7, 2022
@knanao
Copy link
Member

knanao commented Mar 7, 2022

/approve

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Mar 7, 2022

APPROVE

This pull request is APPROVED by knanao.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 9fc1d01 into master Mar 7, 2022
@pipecd-bot pipecd-bot deleted the bazel-proto branch March 7, 2022 07:44
@pipecd-bot pipecd-bot mentioned this pull request Mar 8, 2022
Merged
This was referenced Mar 17, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khanhtc1202 khanhtc1202 khanhtc1202 left review comments

@knanao knanao Awaiting requested review from knanao

Assignees

No one assigned

Labels

approved area/build area/hack area/helloworld area/server area/web lgtm release-note-none size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nghialv @khanhtc1202 @pipecd-bot @knanao