Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Mar 10, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.40%. This pull request does not change code coverage.

@nghialv nghialv requested a review from a team as a code owner March 10, 2022 01:54
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.40%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 78.07%. This pull request does not change code coverage.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice
/approve

- [cmd/pipecd](https://github.com/pipe-cd/pipecd/tree/master/cmd/pipecd): entrypoint for binary of control-plane server.
- [pkg/app/server](https://github.com/pipe-cd/pipecd/tree/master/pkg/app/server): contains source code for control-plane api.
- [pkg/app/web](https://github.com/pipe-cd/pipecd/tree/master/pkg/app/web): contains source code for control-plane web.
- [web](https://github.com/pipe-cd/pipecd/tree/master/web): contains source code for the web console.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first time the web console word be used officially 😄

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants