Add index to CompletedAt #3388
Add index to CompletedAt #3388
Conversation
|
Code coverage for golang is
|
|
|
||
| -- index on `CompletedAt` ASC | ||
| ALTER TABLE Deployment ADD COLUMN CompletedAt INT(11) GENERATED ALWAYS AS (data->>"$.completed_at") VIRTUAL NULL; | ||
| CREATE INDEX deployment_completed_at ON Deployment (CompletedAt); |
There was a problem hiding this comment.
nits, I don't think we need this index, instead of making this, maybe multiple columns index on CompletedAt and Id column is better, since this CompletedAt column is not be referred independently but in query with other columns. Should use explain query and check it out on MySQL cli.
There was a problem hiding this comment.
Thank you, I'll check it.
|
I fixed it. PTAL. |
|
Nice work, thanks 🙌 |
|
/approve cancel |
| ALTER TABLE Deployment ADD COLUMN PipedId VARCHAR(36) GENERATED ALWAYS AS (data->>"$.piped_id") VIRTUAL NOT NULL; | ||
| CREATE INDEX deployment_piped_id ON Deployment (PipedId); | ||
|
|
||
| -- index on `CompletedAt` DESC |
There was a problem hiding this comment.
nits, this should be on CompletedAt and Id
There was a problem hiding this comment.
Thank you. I updated, PTAL
|
Code coverage for golang is
|
|
Thanks 🙌 |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
What this PR does / why we need it:
Currently, completedAt does not exists on mysql column, and so order by completedAt will be failed.
To fix this, this PR create generated column of completedAt and add index to it. CompletedAt is nullable.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: