Skip to content

Fix func name #3306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pipecd-bot merged 1 commit into from
Feb 22, 2022
Merged

Fix func name #3306

pipecd-bot merged 1 commit into from
Feb 22, 2022

Conversation

@Hosshii
Copy link
Member

@Hosshii Hosshii commented Feb 22, 2022 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Feb 22, 2022

COVERAGE

Code coverage for golang is 32.53%. This pull request increases coverage by 0.00%.

File Function Base Head Diff
pkg/app/piped/executor/kubernetes/kubernetes.go addBuiltinAnnotations -- 100.00% +100.00%
pkg/app/piped/executor/kubernetes/kubernetes.go addBuiltinAnnontations 100.00% -- -100.00%

knanao
knanao reviewed Feb 22, 2022
View reviewed changes
Copy link
Member

@knanao knanao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
/approve

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Feb 22, 2022

APPROVE

This pull request is APPROVED by knanao.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 9fc1394 into master Feb 22, 2022
@pipecd-bot pipecd-bot deleted the fix_name branch February 22, 2022 04:58
@pipecd-bot pipecd-bot mentioned this pull request Mar 1, 2022
Merged
@pipecd-bot pipecd-bot mentioned this pull request Mar 8, 2022
Merged
This was referenced Mar 17, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202

@nghialv nghialv Awaiting requested review from nghialv

1 more reviewer

@knanao knanao knanao left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved area/piped release-note-none size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hosshii @pipecd-bot @knanao