Refactor kubernetes provider by separating Loader and Applier #3407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipecd-bot
reviewed
Mar 17, 2022
Collaborator
pipecd-bot
left a comment
pipecd-bot
left a comment
There was a problem hiding this comment.
Some issues were detected while linting go source files in your changes.
Member
Author
|
There is a bug in our CodeGen job so please ignore it in this case. |
Collaborator
knanao
reviewed
Mar 17, 2022
Comment on lines
39
to
42
| type ManifestLoader interface { | ||
| // LoadManifests renders and loads all manifests for application. | ||
| LoadManifests(ctx context.Context) ([]Manifest, error) | ||
| } |
Member
There was a problem hiding this comment.
nits, I would prefer either fixing to ManifestLoader into Loader or LoadManifests into Load.
Member
Author
There was a problem hiding this comment.
Nice idea. Let me fix the interface name to Loader. 👍
Collaborator
|
Code coverage for golang is
|
Member
|
Here you go 👌 |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
This was referenced Mar 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This separates Loader and Applier completely before updating the Applier to use the specified kube-config path.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: