Skip to content

Delete login name check #3327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pipecd-bot merged 2 commits into from
Mar 1, 2022
Merged

Delete login name check #3327

pipecd-bot merged 2 commits into from
Mar 1, 2022

Conversation

@Hosshii
Copy link
Member

@Hosshii Hosshii commented Mar 1, 2022 •
edited by nghialv
Loading

What this PR does / why we need it:
Stop checking github login name to find previous plan-preview comment in case the bot name is changed.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Fix a bug that previous plan-preview comments are not hidden if a customized bot name was used

@Hosshii
Delete login name check
f6d5ae6 
**What this PR does / why we need it**:
Stop checking github login name to find previous plan-preview comment in case the bot name is changed.

**Which issue(s) this PR fixes**:

Fixes #2865

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
-->
```release-note
NONE
```
@nghialv
Copy link
Member

nghialv commented Mar 1, 2022

Please update the version in DOCKERBUILD to release a new docker image for this action.

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Mar 1, 2022

DOCKER

A Kapetanios build has just been triggered to run docker operations for the following 1 directory.
Their results will be reported back after the build is completed.

  1. dockers/actions-plan-preview

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Mar 1, 2022

DOCKER

The Kapetanios build to run docker operations for the following 1 directory has been completed.

1. dockers/actions-plan-preview - success

An image named actions-plan-preview:1.6.0-d646db9 was procuded for reviewing and testing.
By merging this PR, an image named actions-plan-preview:1.6.0 will be pushed to the container registry.

There is no test to run inside this directory.

@nghialv
Copy link
Member

nghialv commented Mar 1, 2022

Thank you.
/approve

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Mar 1, 2022

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Mar 1, 2022

COVERAGE

Code coverage for golang is 32.39%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot merged commit a93b802 into master Mar 1, 2022
@pipecd-bot pipecd-bot deleted the Hosshii-patch-1 branch March 1, 2022 07:32
@pipecd-bot pipecd-bot mentioned this pull request Mar 8, 2022
Merged
This was referenced Mar 17, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202

@knanao knanao Awaiting requested review from knanao

@nghialv nghialv Awaiting requested review from nghialv

Assignees

No one assigned

Labels

approved size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hosshii @nghialv @pipecd-bot