Remove storybook from web code #3339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Code coverage for golang is |
Collaborator
|
Code coverage for javascript is |
khanhtc1202
reviewed
Mar 4, 2022
| "lint": "eslint --ext .ts,.tsx ./src", | ||
| "lint:fix": "eslint --fix --ext .ts,.tsx ./src", | ||
| "storybook": "start-storybook -p 6006", | ||
| "build-storybook": "build-storybook", |
Member
There was a problem hiding this comment.
should we remove storybook-related dependencies as well? this file at line L22-24
Member
Author
There was a problem hiding this comment.
Nice catch!
Tbh, not sure why but the build does not pass when I remove them. So weird!
Let me deal with them in another PR.
Member
|
Thanks Storybook for your serve |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
This was referenced Mar 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is one of the steps to simplify our development process and codebase.
This PR removes all storybook files since they have become quite outdated compared to our recent UI changes and we don't use them much in our development process.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: