Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Mar 1, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3221

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

DOCKER

Unabled to get changed files of pull request.

Details
Error: rpc error: code = NotFound desc = not found

@knanao
Copy link
Member

knanao commented Mar 1, 2022

Finally🙌
/lgtm

@pipecd-bot pipecd-bot added the lgtm label Mar 1, 2022
@khanhtc1202
Copy link
Member

Thank you 🙆‍♀️
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.39%. This pull request increases coverage by 0.01%.

File Function Base Head Diff
pkg/datastore/mysql/model_wrapper.go wrapModel 0.00% 0.00% +0.00%

@pipecd-bot pipecd-bot merged commit 1f84eef into master Mar 1, 2022
@pipecd-bot pipecd-bot deleted the environment branch March 1, 2022 01:43
@nghialv
Copy link
Member Author

nghialv commented Mar 1, 2022

/changelog

@pipecd-bot
Copy link
Collaborator

CHANGELOG

@nghialv: Changelog has been generated in response to this comment.

Details

Changelog since v0.26.0

Notable Changes

  • Allow filtering suggested applications by using a new appSelector field in Piped config (#3320)
  • Enable to view Application live state for Cloud Run (#3301)
  • Implement live state reporter for Cloud Run (#3284)

Internal Changes

  • Remove environment model (#3324)
  • Implement create interface for filedb database (#3322)
  • Add description to the examples (#3321)
  • Add ContainLabels method for ApplicationInfo (#3319)
  • Add appSelector field for piped (#3318)
  • Add merge shards data for multiple shards stored object (#3316)
  • Define unregistered app cache (#3313)
  • change the port number of the local registry for macOS Montray (#3315)
  • Update feature status docs for Cloud Run (#3311)
  • Remove unused envCache (#3309)
  • Add proto message for better running version of applicaion (#3307)
  • Rename the title of Running Version column to Artifact Versions (#3308)
  • Fix func name (#3306)
  • Upgrade rules_go to v0.30.0 and go to 1.1.7.6 (#3305)
  • Remove gRPC related to env from auth (#3304)
  • Remove Environment related APIs (#3300)
  • Remove env related unused code from web (#3302)
  • Implement get interface for FileDB (#3286)
  • Fix typo (#3298)
  • Update actions-plan-preview to use pipectl v0.26.0 (#3297)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Environment concept from models

5 participants